datepicker timezone issue on view layer fixed #1168

barshat7 · 2024-04-08T07:12:50Z

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

I have signed the Adobe Open Source CLA.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes and the overall coverage did not decrease.
All unit tests pass on CircleCi.
I ran all tests locally and they pass.

rismehta · 2024-04-08T07:26:20Z

...apps/core/fd/components/form/datepicker/v1/datepicker/clientlibs/site/js/datepickerwidget.js

+       * We only test for 'yyyy-MM-dd' because timezone related issue only occurs when date is selected from calendar.
+       * And calendar only sets value in yyyy-MM-dd
+       */
+      if (isDateDefaultFormat(value)) {


Date will always come in this format, why have you added this check ? We don't support any other format in saveValue.

If a user manually enters some other date format from the input widget

For saveValue there is no formatting, you don't need this check. Formatting is only for display/edit value

adobe-bot · 2024-04-08T07:41:34Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	91	100	100	73

adobe-bot · 2024-04-08T07:41:34Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	100	100	73

adobe-bot · 2024-04-08T07:41:46Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-04-08T07:42:17Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-04-08T07:42:38Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

codecov · 2024-04-08T07:46:11Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.75%. Comparing base (64d220a) to head (74bbd69).

Additional details and impacted files

@@            Coverage Diff            @@
##                dev    #1168   +/-   ##
=========================================
  Coverage     80.75%   80.75%           
  Complexity      773      773           
=========================================
  Files            91       91           
  Lines          2110     2110           
  Branches        285      285           
=========================================
  Hits           1704     1704           
  Misses          252      252           
  Partials        154      154

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sakshi-arora1 · 2024-04-08T11:25:58Z

...apps/core/fd/components/form/datepicker/v1/datepicker/clientlibs/site/js/datepickerwidget.js

@@ -1119,10 +1119,6 @@ if (typeof window.DatePickerWidget === 'undefined') {
      if (this.#isEditValueOrDisplayValue(this.#widget.value)) {
        return this.#model.value; // if the widget has edit/display value thus method should return model value
      }
-      let dateVal = new Date(this.toString());
-      if (!isNaN(dateVal)) {


Why was this added earlier?

adobe-bot · 2024-04-08T11:38:08Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	100	100	73

adobe-bot · 2024-04-08T11:38:08Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	92	100	100	73

adobe-bot · 2024-04-08T11:38:19Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-04-08T11:39:03Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-04-08T11:39:44Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

rismehta · 2024-04-08T12:01:05Z

...apps/core/fd/components/form/datepicker/v1/datepicker/clientlibs/site/js/datepickerwidget.js

@@ -1119,10 +1119,6 @@ if (typeof window.DatePickerWidget === 'undefined') {
      if (this.#isEditValueOrDisplayValue(this.#widget.value)) {
        return this.#model.value; // if the widget has edit/display value thus method should return model value
      }
-      let dateVal = new Date(this.toString());


I don't think this should be removed

datepicker timezone issue on view layer fixed datepicker timezone issue on view layer fixed

adobe-bot · 2024-04-11T08:08:09Z

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	92	100	100	73

adobe-bot · 2024-04-11T08:08:09Z

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	100	100	73

adobe-bot · 2024-04-11T08:08:20Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-04-11T08:09:37Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot · 2024-04-11T08:11:38Z

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

rismehta · 2024-04-11T08:31:14Z

...t/apps/core/fd/components/form/datepicker/v1/datepicker/clientlibs/site/js/datepickerview.js

@@ -99,6 +99,12 @@
                    this.widgetObject.setValue(e.target.value);
                    this.setActive();
                }, this.getWidget());
+                this.widgetObject.addEventListener('input', (e) => {


I am not sure how is this change related to the current issue.

This issue is not directly related to timezone issue, but when we fix the timezone, this issue manifests in one of the test case.
Reason being that we were not clearing the value of the input field when user emptied it. (We do that from calendar icon but I think this was missed when manual entry of date was implemented).

aem-core-forms-components/ui.af.apps/src/main/content/jcr_root/apps/core/fd/components/form/datepicker/v1/datepicker/clientlibs/site/js/datepickerwidget.js

Line 1010 in ac6f9b7

#clearDate(view) {

rismehta · 2024-04-11T08:31:52Z

...apps/core/fd/components/form/datepicker/v1/datepicker/clientlibs/site/js/datepickerwidget.js

@@ -1194,6 +1197,9 @@ if (typeof window.DatePickerWidget === 'undefined') {
          case 'focus':
            handler(e);
            break;
+          case 'input':


Why do you need this listener in the current CL? Please fix this as a separate JIRA

PR will not pass if this is not fixed, or will have to comment out a test case

rismehta

check comments

* datepicker timezone issue on view layer fixed datepicker timezone issue on view layer fixed datepicker timezone issue on view layer fixed * datepicker fix test case

barshat7 mentioned this pull request Apr 8, 2024

DO-NOT-MERGE datepicker selecting previous day for UTC-3 TZ fixed #1161

Closed

10 tasks

rismehta reviewed Apr 8, 2024

View reviewed changes

sakshi-arora1 reviewed Apr 8, 2024

View reviewed changes

rismehta reviewed Apr 8, 2024

View reviewed changes

barshat7 added 2 commits April 11, 2024 12:14

datepicker timezone issue on view layer fixed

793019e

datepicker timezone issue on view layer fixed datepicker timezone issue on view layer fixed

datepicker fix test case

74bbd69

barshat7 force-pushed the datepicker-tz-issue-fix branch from 6484722 to 74bbd69 Compare April 11, 2024 07:47

rismehta reviewed Apr 11, 2024

View reviewed changes

rismehta requested changes Apr 11, 2024

View reviewed changes

sakshi-arora1 approved these changes Apr 11, 2024

View reviewed changes

rismehta approved these changes Apr 11, 2024

View reviewed changes

rismehta merged commit 6556e4f into dev Apr 11, 2024
11 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

datepicker timezone issue on view layer fixed #1168

datepicker timezone issue on view layer fixed #1168

barshat7 commented Apr 8, 2024

rismehta Apr 8, 2024 •

edited

barshat7 Apr 8, 2024

rismehta Apr 8, 2024 •

edited

adobe-bot commented Apr 8, 2024

adobe-bot commented Apr 8, 2024

adobe-bot commented Apr 8, 2024

adobe-bot commented Apr 8, 2024

adobe-bot commented Apr 8, 2024

codecov bot commented Apr 8, 2024 •

edited

sakshi-arora1 Apr 8, 2024

adobe-bot commented Apr 8, 2024

adobe-bot commented Apr 8, 2024

adobe-bot commented Apr 8, 2024

adobe-bot commented Apr 8, 2024

adobe-bot commented Apr 8, 2024

rismehta Apr 8, 2024

adobe-bot commented Apr 11, 2024

adobe-bot commented Apr 11, 2024

adobe-bot commented Apr 11, 2024

adobe-bot commented Apr 11, 2024

adobe-bot commented Apr 11, 2024

rismehta Apr 11, 2024

barshat7 Apr 11, 2024

rismehta Apr 11, 2024

barshat7 Apr 11, 2024

rismehta left a comment

datepicker timezone issue on view layer fixed #1168

datepicker timezone issue on view layer fixed #1168

Conversation

barshat7 commented Apr 8, 2024

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

rismehta Apr 8, 2024 • edited

Choose a reason for hiding this comment

barshat7 Apr 8, 2024

Choose a reason for hiding this comment

rismehta Apr 8, 2024 • edited

Choose a reason for hiding this comment

adobe-bot commented Apr 8, 2024

Lighthouse scores (mobile)

adobe-bot commented Apr 8, 2024

Lighthouse scores (desktop)

adobe-bot commented Apr 8, 2024

Accessibility Violations Found

adobe-bot commented Apr 8, 2024

Accessibility Violations Found

adobe-bot commented Apr 8, 2024

Accessibility Violations Found

codecov bot commented Apr 8, 2024 • edited

Codecov Report

sakshi-arora1 Apr 8, 2024

Choose a reason for hiding this comment

adobe-bot commented Apr 8, 2024

Lighthouse scores (desktop)

adobe-bot commented Apr 8, 2024

Lighthouse scores (mobile)

adobe-bot commented Apr 8, 2024

Accessibility Violations Found

adobe-bot commented Apr 8, 2024

Accessibility Violations Found

adobe-bot commented Apr 8, 2024

Accessibility Violations Found

rismehta Apr 8, 2024

Choose a reason for hiding this comment

adobe-bot commented Apr 11, 2024

Lighthouse scores (mobile)

adobe-bot commented Apr 11, 2024

Lighthouse scores (desktop)

adobe-bot commented Apr 11, 2024

Accessibility Violations Found

adobe-bot commented Apr 11, 2024

Accessibility Violations Found

adobe-bot commented Apr 11, 2024

Accessibility Violations Found

rismehta Apr 11, 2024

Choose a reason for hiding this comment

barshat7 Apr 11, 2024

Choose a reason for hiding this comment

rismehta Apr 11, 2024

Choose a reason for hiding this comment

barshat7 Apr 11, 2024

Choose a reason for hiding this comment

rismehta left a comment

Choose a reason for hiding this comment

rismehta Apr 8, 2024 •

edited

rismehta Apr 8, 2024 •

edited

codecov bot commented Apr 8, 2024 •

edited