FORMS-13851 Support for language in date picker and number input #1169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rismehta
changed the title
rismehta
changed the title
Lighthouse scores (mobile)
|
Lighthouse scores (desktop)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1169 +/- ##
============================================
+ Coverage 80.75% 80.81% +0.05%
- Complexity 773 782 +9
============================================
Files 91 91
Lines 2110 2116 +6
Branches 285 286 +1
============================================
+ Hits 1704 1710 +6
Misses 252 252
Partials 154 154 ☔ View full report in Codecov by Sentry. |
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
vdua
reviewed
Apr 16, 2024
| ContentPolicy policy = ComponentUtils.getPolicy((String) request.getAttribute(Value.CONTENTPATH_ATTRIBUTE), | ||
| resourceResolver); | ||
| resources.add(getResourceForDropdownDisplay(resourceResolver, "Select", "")); | ||
| if (policy != null) { | ||
| ValueMap props = policy.getProperties(); | ||
| if (props != null) { | ||
| for (Map.Entry<String, Object> entry : props.entrySet()) { | ||
| if (entry.getKey().startsWith(ALLOWED_FORMAT)) { | ||
| if ((type.equals(FormMetaDataType.FORMATTERS) && entry.getKey().startsWith(ALLOWED_FORMAT)) || | ||
| (type.equals(FormMetaDataType.LANG) && entry.getKey().startsWith(FormMetaDataType.LANG.getValue()))) { |
There was a problem hiding this comment.
I would suggest making private functions and using that here for readability, something like below
if (isFormattersPolicy(type, entry) || isLangPolicy(type, entry))
vdua
reviewed
Apr 16, 2024
bundles/af-core/src/main/java/com/adobe/cq/forms/core/components/util/AbstractBaseImpl.java
Show resolved
Hide resolved
vdua
reviewed
Apr 16, 2024
| @@ -17,6 +17,8 @@ | |||
| "enabled": false, | |||
| "readOnly": true, | |||
| "required": false, | |||
| "lang" : "it-IT", | |||
| "langDisplayValue" : "it-IT", | |||
There was a problem hiding this comment.
This is internal JCR structure of lang, since we have a drop down which does listing of all the OOTB lang and there is another text box which stores the value, hence there are two properties
vdua
reviewed
Apr 16, 2024
| cy.get(`#${numberInput6}`).find("input").clear().type(input).blur().then(x => { | ||
| expect(Number(model.getState().value)).to.equal(Number(input)); | ||
| // Assert that the input value contains "121" and "212,000" regardless of the space type | ||
| cy.get(`#${numberInput6}`).find('input').invoke('val').should('match', /121.*212,000/); |
There was a problem hiding this comment.
value should be 121.121,00 why are we using regex to match it ?
There was a problem hiding this comment.
There is some space in the display pattern, hence a regex is required to match
There was a problem hiding this comment.
Ideally space should not come. With space the the correct regex should be 121\.\s*121,000
github-actions
bot
force-pushed
the
fieldlang
branch
from
2a5d1a3
to
ff2d6f3
Compare
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
|
Merging since this is reviewed by @vdua |
Lighthouse scores (mobile)
|
Lighthouse scores (desktop)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
vdua
approved these changes
Apr 18, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Apr 18, 2024
* FORMS-13851 Support for language in date picker and number input @review @vdua DOD(Yes) * FORMS-13851 Support for language in date picker and number input @review @vdua DOD(Yes) * FORMS-13851 Support for language in date picker and number input @review @vdua DOD(Yes) * FORMS-13851 Support for language in date picker and number input @review @vdua DOD(Yes) * FORMS-13851 Support for language in date picker and number input @review @vdua DOD(Yes) * FORMS-13851 Support for language in date picker and number input @review @vdua DOD(Yes) * FORMS-13851 Support for language in date picker and number input @review @vdua DOD(Yes) * FORMS-13851 Support for language in date picker and number input @review @vdua DOD(Yes) * Update space character for thousands separator in french lang * FORMS-13851 Support for language in date picker and number input @review @vdua DOD(Yes) --------- Co-authored-by: Varun Dua <vdua@adobe.com>
github-actions bot
pushed a commit
that referenced
this pull request
May 7, 2024
* FORMS-13851 Support for language in date picker and number input @review @vdua DOD(Yes) * FORMS-13851 Support for language in date picker and number input @review @vdua DOD(Yes) * FORMS-13851 Support for language in date picker and number input @review @vdua DOD(Yes) * FORMS-13851 Support for language in date picker and number input @review @vdua DOD(Yes) * FORMS-13851 Support for language in date picker and number input @review @vdua DOD(Yes) * FORMS-13851 Support for language in date picker and number input @review @vdua DOD(Yes) * FORMS-13851 Support for language in date picker and number input @review @vdua DOD(Yes) * FORMS-13851 Support for language in date picker and number input @review @vdua DOD(Yes) * Update space character for thousands separator in french lang * FORMS-13851 Support for language in date picker and number input @review @vdua DOD(Yes) --------- Co-authored-by: Varun Dua <vdua@adobe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@review @vdua
DOD(Yes)
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: