FORMS-12667 Update type property on replacing checkboxgroup to radio group #1176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1176 +/- ##
=========================================
Coverage 80.75% 80.75%
Complexity 773 773
=========================================
Files 91 91
Lines 2110 2110
Branches 285 285
=========================================
Hits 1704 1704
Misses 252 252
Partials 154 154 ☔ View full report in Codecov by Sentry. |
rismehta
reviewed
Apr 9, 2024
| @@ -3,6 +3,7 @@ | |||
| jcr:primaryType="nt:unstructured" | |||
| jcr:title="Radio Button" | |||
| fieldType="radio-group" | |||
| type="number" | |||
There was a problem hiding this comment.
Any reasons for adding type to OOTB component ?
There was a problem hiding this comment.
In enum we are providing enum="[0,1] , this is similar to checkbox group but there we have mentioned number type [1]
[1]:
|
Please add JIRA id to the commit message |
dmaurya929
changed the title
rismehta
reviewed
Apr 9, 2024
ui.tests/test-module/specs/replaceaction/replacelayout-container.authoring.spec.js
Outdated
Show resolved
Hide resolved
github-actions
bot
force-pushed
the
fix-replacector
branch
from
25efeba
to
4a0d5c8
Compare
Lighthouse scores (mobile)
|
Lighthouse scores (desktop)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
rismehta
approved these changes
Apr 10, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Apr 11, 2024
…group (#1176) * Update type property on replacing checkboxgroup to radio group * FORMS-12667 review comment --------- Co-authored-by: demaurya <demaurya@adobe.com>
github-actions bot
pushed a commit
that referenced
this pull request
May 7, 2024
…group (#1176) * Update type property on replacing checkboxgroup to radio group * FORMS-12667 review comment --------- Co-authored-by: demaurya <demaurya@adobe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: