Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving to 15860 image #1212

Merged
merged 3 commits into from
May 2, 2024
Merged

Moving to 15860 image #1212

merged 3 commits into from
May 2, 2024

Conversation

rismehta
Copy link
Collaborator

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@adobe-bot
Copy link

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 93 96 100 75

@adobe-bot
Copy link

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 100 75

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

@adobe-bot
Copy link

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 100 75

@adobe-bot
Copy link

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 94 96 100 75

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

1 similar comment
@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious

Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.81%. Comparing base (9de36fd) to head (8bfe4f9).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #1212   +/-   ##
=========================================
  Coverage     80.81%   80.81%           
  Complexity      782      782           
=========================================
  Files            91       91           
  Lines          2116     2116           
  Branches        286      286           
=========================================
  Hits           1710     1710           
  Misses          252      252           
  Partials        154      154           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rismehta rismehta merged commit c227001 into dev May 2, 2024
10 checks passed
@rismehta rismehta deleted the 15860 branch May 2, 2024 09:56
github-actions bot pushed a commit that referenced this pull request May 3, 2024
* Moving to 15860 image

* updating core component version

* Skipping wizard authoring test
github-actions bot pushed a commit that referenced this pull request May 7, 2024
* Moving to 15860 image

* updating core component version

* Skipping wizard authoring test
barshat7 added a commit that referenced this pull request May 10, 2024
Revert "Moving to 15860 image (#1212)"

This reverts commit c227001.
sakshi-arora1 pushed a commit that referenced this pull request May 10, 2024
Revert "Moving to 15860 image (#1212)"

This reverts commit c227001.
github-actions bot pushed a commit that referenced this pull request May 10, 2024
Revert "Moving to 15860 image (#1212)"

This reverts commit c227001.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants