Supporting getFormDefinition for UE #1237
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lighthouse scores (mobile)
|
Lighthouse scores (desktop)
|
Accessibility Violations Found
|
nit23uec
reviewed
May 16, 2024
| @@ -362,4 +367,18 @@ public String getName() { | |||
| return FormContainer.super.getName(); | |||
| } | |||
|
|
|||
| @JsonIgnore | |||
There was a problem hiding this comment.
jsonignore should not be required in impl, I guess.
There was a problem hiding this comment.
I see it being used in other methods above of the same class, and so maybe it is?
cc: @rismehta
rismehta
reviewed
May 16, 2024
| * @return A String that consists of the form container json | ||
| */ | ||
| @JsonIgnore | ||
| default String getFormDefinition() { |
There was a problem hiding this comment.
This is already part of FormStructureParser and it is merged. Why do we have another PR for this ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: