Encode formDefinition with jsonString context #1242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TalmizAhmed
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1242 +/- ##
=========================================
Coverage 81.41% 81.41%
Complexity 818 818
=========================================
Files 94 94
Lines 2201 2201
Branches 301 301
=========================================
Hits 1792 1792
Misses 252 252
Partials 157 157 ☔ View full report in Codecov by Sentry. |
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
3 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
Accessibility Violations Found
|
TalmizAhmed
changed the title
|
Support for jsonString context is now available in public AEM cloud release Release 16357 |
What is the behavior of the code if context is not available ? Is the rendering blocked |
|
@rismehta No the rendering would just be in the default context of the html tag, without the encoding provided by jsonString |
|
@rismehta This test case will be improved by @deepprakash345 to include checks for this use case too and is being tracked by a separate ticket (FORMS-14628) |
github-actions
bot
force-pushed
the
eds-encoding-support
branch
from
d755a7d
to
3e1d92e
Compare
Lighthouse scores (mobile)
|
Lighthouse scores (desktop)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
added 2 commits
June 5, 2024 10:04
…a test case to check the json emitted in case of eds servlet originated request
…ore-forms-components into eds-encoding-support
…a test case to check the json emitted in case of eds servlet originated request
github-actions
bot
force-pushed
the
eds-encoding-support
branch
from
0491f05
to
34862cf
Compare
…a test case to check the json emitted in case of eds servlet originated request
Lighthouse scores (mobile)
|
Lighthouse scores (desktop)
|
Accessibility Violations Found
|
4 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
Accessibility Violations Found
|
Accessibility Violations Found
|
Lighthouse scores (mobile)
|
Lighthouse scores (desktop)
|
Accessibility Violations Found
|
added 2 commits
June 5, 2024 13:13
…a test case to check the json emitted in case of eds servlet originated request
…a test case to check the json emitted in case of eds servlet originated request
Lighthouse scores (mobile)
|
Lighthouse scores (desktop)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
rismehta
approved these changes
Jun 5, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jun 6, 2024
* Encode formDefinition with jsonString context * Encode formDefinition with jsonString context * updated the proxy component to point to v2 version of page and wrote a test case to check the json emitted in case of eds servlet originated request * Encode formDefinition with jsonString context * updated the proxy component to point to v2 version of page and wrote a test case to check the json emitted in case of eds servlet originated request * updated the proxy component to point to v2 version of page and wrote a test case to check the json emitted in case of eds servlet originated request * updated the proxy component to point to v2 version of page and wrote a test case to check the json emitted in case of eds servlet originated request --------- Co-authored-by: Deep Prakash Dewanji <deepprakashdewanji@labusers-mbp-9.corp.adobe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: