FORMS-14125: Exposed all spec function in globals, updated af2-web-ru… #1244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 20, 2024 16:03
github-actions
bot
force-pushed
the
FORMS-14125
branch
from
659b92e
to
de70a04
Compare
rismehta
reviewed
May 21, 2024
| @@ -86,4 +86,44 @@ describe('Form with custom functions configured in client lib', () => { | |||
| }); | |||
| } | |||
| }) | |||
|
|
|||
| it("should import formData on button click", () => { | |||
| if (cy.af.isLatestAddon() && toggle_array.includes("FT_FORMS-11541")) { | |||
There was a problem hiding this comment.
Why is this FT required ?
There was a problem hiding this comment.
Passing globals object in scope param feature is behind this FT.
rismehta
requested changes
May 21, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1244 +/- ##
=========================================
Coverage 81.32% 81.32%
Complexity 813 813
=========================================
Files 94 94
Lines 2185 2185
Branches 298 298
=========================================
Hits 1777 1777
Misses 252 252
Partials 156 156 ☔ View full report in Codecov by Sentry. |
added 2 commits
May 23, 2024 10:31
Lighthouse scores (mobile)
|
Lighthouse scores (desktop)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
added 6 commits
May 23, 2024 11:01
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
Lighthouse scores (mobile)
|
Lighthouse scores (desktop)
|
Accessibility Violations Found
|
Accessibility Violations Found
|
1 similar comment
Accessibility Violations Found
|
rismehta
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ntime version
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: