Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev2master 15 jun23 #707

Merged
merged 37 commits into from
Jun 14, 2023
Merged

Dev2master 15 jun23 #707

merged 37 commits into from
Jun 14, 2023

Conversation

ujjwal5
Copy link
Contributor

@ujjwal5 ujjwal5 commented Jun 14, 2023

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

tyagiaditi and others added 30 commits April 21, 2023 17:30
* Update working directory for release job

* Change ssh key to ECDSA encryption rather than RSA
…without refresh in case of horizontal and vertical tabs (#696)

* [FORMS-7828] resolved problem of navigation not working in authoring without refresh in case of horizontal and vertical tabs

* [FORMS-7828] fixed flaky authoring tests in numberinput/datepicker.....

---------

Co-authored-by: Deep Prakash Dewanji <deepprakashdewanji@labusers-mbp-5.macromedia.com>
…#701)

* FORMS-3225 Fix for blank title getting replaced with component's name

* FORMS-3225 Incorporated the review comments
@adobe-bot
Copy link

Lighthouse scores

Performance Accessibility Best-Practices SEO
Scores 96 93 92 71

@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Merging #707 (cbad74a) into master (b729309) will decrease coverage by 0.54%.
The diff coverage is 46.66%.

@@             Coverage Diff              @@
##             master     #707      +/-   ##
============================================
- Coverage     79.47%   78.93%   -0.54%     
- Complexity      651      656       +5     
============================================
  Files            82       84       +2     
  Lines          1871     1899      +28     
  Branches        239      243       +4     
============================================
+ Hits           1487     1499      +12     
- Misses          247      261      +14     
- Partials        137      139       +2     
Impacted Files Coverage Δ
...s/core/components/internal/form/FormConstants.java 100.00% <ø> (ø)
...nts/internal/models/v1/form/FormContainerImpl.java 50.00% <ø> (ø)
...rms/core/components/models/form/FormContainer.java 19.23% <0.00%> (-0.77%) ⬇️
...q/forms/core/components/models/form/Recaptcha.java 0.00% <0.00%> (ø)
...ore/components/util/AbstractFormComponentImpl.java 87.93% <ø> (ø)
...nts/internal/models/v2/form/FormContainerImpl.java 54.54% <11.11%> (-7.53%) ⬇️
...ponents/internal/models/v1/form/RecaptchaImpl.java 68.75% <68.75%> (ø)
...q/forms/core/components/models/form/FieldType.java 88.46% <100.00%> (+0.46%) ⬆️
...q/forms/core/components/util/AbstractBaseImpl.java 75.78% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ujjwal5 ujjwal5 merged commit 07bf750 into master Jun 14, 2023
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants