Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev to Master #902

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Dev to Master #902

merged 1 commit into from
Oct 4, 2023

Conversation

ravise5
Copy link
Contributor

@ravise5 ravise5 commented Oct 4, 2023

  • Update af-core version

  • Fixed test cases

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

* Update af-core version

* Fixed test cases
@ravise5 ravise5 requested a review from rismehta October 4, 2023 05:26
@adobe-bot
Copy link

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 90 100 100 73

@adobe-bot
Copy link

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 100 100 73

@adobe-bot
Copy link

Accessibility Violations Found

Id Impact
label-title-only serious
landmark-one-main moderate
region moderate

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #902 (aaa0e82) into master (2216f1d) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #902   +/-   ##
=========================================
  Coverage     80.07%   80.07%           
  Complexity      714      714           
=========================================
  Files            87       87           
  Lines          2023     2023           
  Branches        269      269           
=========================================
  Hits           1620     1620           
  Misses          254      254           
  Partials        149      149           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rismehta rismehta merged commit 8b30f3b into master Oct 4, 2023
10 checks passed
@rismehta rismehta deleted the dev2Master branch October 4, 2023 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants