Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Accordion][DataLayer] Accordions in Experience Fragments do not work when DataLayer is activated #1339

Closed
vladbailescu opened this issue Jan 12, 2021 · 0 comments
Closed

[Accordion][DataLayer] Accordions in Experience Fragments do not work when DataLayer is activated #1339

vladbailescu opened this issue Jan 12, 2021 · 0 comments
Assignees
@vladbailescu
Labels
bug Unexpected problem or unintended behavior that impairs normal functioning of the product.
Milestone
2.13.4

Comments

@vladbailescu
Copy link
Member

When adding an accordion to a page via an experience fragment, the accordion does not work, logging the following in JS console:

VM1544:1 Uncaught SyntaxError: Unexpected token u in JSON at position 0
    at JSON.parse (<anonymous>)
    at getDataLayerId (clientlib-base.js:582)
    at setItemExpanded (clientlib-base.js:418)
    at toggle (clientlib-base.js:371)
    at HTMLButtonElement.<anonymous> (clientlib-base.js:295)
@vladbailescu vladbailescu added the bug Unexpected problem or unintended behavior that impairs normal functioning of the product. label Jan 12, 2021
@vladbailescu vladbailescu added this to the 2.14.0 milestone Jan 12, 2021
@vladbailescu vladbailescu self-assigned this Jan 12, 2021
vladbailescu added a commit that referenced this issue Jan 12, 2021
@vladbailescu
[Accordion][DataLayer] Accordions in Experience Fragments do not work…
8a11cea 
… when DataLayer is activated #1339

* Getting the datalayer state from the current page (which gets passed as a parameter for panel container items) so that TemplatedResources render the datalayer information correctly.
vladbailescu added a commit that referenced this issue Jan 12, 2021
@vladbailescu
[Accordion][DataLayer] Accordions in Experience Fragments do not work…
297c9a0 
… when DataLayer is activated #1339

* Added checks to make parsing of datalayer JSON more robust
@vladbailescu vladbailescu mentioned this issue Jan 12, 2021
Merged
vladbailescu added a commit that referenced this issue Jan 14, 2021
@vladbailescu
[Accordion][DataLayer] Accordions in Experience Fragments do not work…
a8051f9 
… when DataLayer is activated #1339

* Added test content and end-to-end tests inspired by https://github.com/adobe/aem-project-archetype/tree/master/src/main/archetype/ui.tests/test-module
vladbailescu added a commit that referenced this issue Jan 18, 2021
@vladbailescu
[Accordion][DataLayer] Accordions in Experience Fragments do not work…
61efdc8 
… when DataLayer is activated #1339 (#1340)

* Getting the datalayer state from the current page (which gets passed as a parameter for panel container items) so that TemplatedResources render the datalayer information correctly.
* Added checks to make parsing of datalayer JSON more robust
* Added test content and end-to-end tests inspired by https://github.com/adobe/aem-project-archetype/tree/master/src/main/archetype/ui.tests/test-module

Fixes #1339
@vladbailescu vladbailescu modified the milestones: 2.14.0, 2.13.4 Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vladbailescu vladbailescu

Labels
bug Unexpected problem or unintended behavior that impairs normal functioning of the product.
Projects
None yet
Milestone
2.13.4
Development

No branches or pull requests
1 participant
@vladbailescu