Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Library] Examples do not use proxy components consistently #1452

Closed
vladbailescu opened this issue Mar 17, 2021 · 0 comments · Fixed by #1453
Closed

[Library] Examples do not use proxy components consistently #1452

vladbailescu opened this issue Mar 17, 2021 · 0 comments · Fixed by #1453
Labels
enhancement New feature, or improvement to an existing feature.
Milestone
2.16.0

Comments

@vladbailescu
Copy link
Member

vladbailescu commented Mar 17, 2021 •
edited

Parts of Components Library uses proxy (introduced with AMP features), other parts reference Core Components specific versions directly.
@vladbailescu vladbailescu changed the title [Library [Library] Examples do not use proxy components consistently Mar 17, 2021
@vladbailescu vladbailescu added the enhancement New feature, or improvement to an existing feature. label Mar 17, 2021
vladbailescu added a commit that referenced this issue Mar 17, 2021
@vladbailescu
[Library] Examples do not use proxy components consistently #1452
37d9cb1 
* Updated library to use proxies for all components

Fixes #1452
@vladbailescu vladbailescu mentioned this issue Mar 17, 2021
Merged
vladbailescu added a commit that referenced this issue Mar 18, 2021
@vladbailescu
[Library] Examples do not use proxy components consistently #1452 (#1453
b192bdc 
)

* Updated library to use proxies for all components

Fixes #1452
@vladbailescu vladbailescu linked a pull request Mar 18, 2021 that will close this issue
[Library] Examples do not use proxy components consistently #1452 #1453
Merged
@vladbailescu vladbailescu added this to the 2.16.0 milestone Mar 18, 2021
@vladbailescu vladbailescu mentioned this issue May 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature, or improvement to an existing feature.
Projects
None yet
Milestone
2.16.0
Development

Successfully merging a pull request may close this issue.

[Library] Examples do not use proxy components consistently #1452 adobe/aem-core-wcm-components
1 participant
@vladbailescu