Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Teaser] Inherit page image #1710

Closed
github-jira-sync-bot opened this issue Jul 30, 2021 · 1 comment
Closed

[Teaser] Inherit page image #1710

github-jira-sync-bot opened this issue Jul 30, 2021 · 1 comment
Labels
done enhancement New feature, or improvement to an existing feature.
Milestone
2.17.10

Comments

@github-jira-sync-bot
Copy link
Collaborator

For the teaser component, inherit the image, similar to how it is for the image component, but allow to inherit it from the linked page.
@github-jira-sync-bot github-jira-sync-bot added the in progress Work is underway on implementing this fix or enhancement. label Jul 30, 2021
@github-jira-sync-bot
Copy link
Collaborator Author

The issue was exported from the internal Jira. The original Jira issue: SITES-1758.

jckautzmann added a commit that referenced this issue Jul 30, 2021
@jckautzmann
GH-1710 - [Teaser] Inherit page image
1de714c 
- support inheriting the image and the alternative text from the featured image of the linked page if defined or from the current page
- share the same logic and UI between the Image v3 and Teaser v2
- update current tests
@jckautzmann jckautzmann mentioned this issue Jul 30, 2021
Merged
@github-jira-sync-bot github-jira-sync-bot added in review and removed in progress Work is underway on implementing this fix or enhancement. labels Jul 30, 2021
jckautzmann added a commit that referenced this issue Aug 4, 2021
@jckautzmann
GH-1710 - [Teaser] Inherit page image
354a167 
- improve the dialogs (label and description) of Teaser and Image
jckautzmann added a commit that referenced this issue Aug 4, 2021
@jckautzmann
GH-1710 - [Teaser] Inherit page image (#1711)
00267df 
- support inheriting the image and the alternative text from the featured image of the linked page if defined or from the current page
- share the same logic and UI between the Image v3 and Teaser v2
- update current tests
@github-jira-sync-bot github-jira-sync-bot added to verify issue is resolved, waiting to be tested and verified done and removed in review to verify issue is resolved, waiting to be tested and verified labels Aug 4, 2021
msagolj added a commit that referenced this issue Aug 12, 2021
@msagolj
GH-1710 remove ''/apps' from 'assets' tab include path
c4e0e3f
@richardhand richardhand added this to the 2.17.10 milestone Aug 18, 2021
@richardhand richardhand added the enhancement New feature, or improvement to an existing feature. label Aug 18, 2021
msagolj added a commit that referenced this issue Aug 18, 2021
@msagolj
GH-1710 adapt Selenium Tests for Teaser v2
90cd434
richardhand pushed a commit that referenced this issue Aug 19, 2021
@jckautzmann @richardhand
GH-1710 - [Teaser] Inherit page image (#1711)
3b6f761 
- support inheriting the image and the alternative text from the featured image of the linked page if defined or from the current page
- share the same logic and UI between the Image v3 and Teaser v2
- update current tests
richardhand pushed a commit that referenced this issue Aug 19, 2021
@msagolj @richardhand
GH-1710 remove ''/apps' from 'assets' tab include path
b3c20bd
richardhand pushed a commit that referenced this issue Aug 19, 2021
@msagolj @richardhand
GH-1710 adapt Selenium Tests for Teaser v2
a8f24a5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
done enhancement New feature, or improvement to an existing feature.
Projects
None yet
Milestone
2.17.10
Development

No branches or pull requests
2 participants
@richardhand @github-jira-sync-bot