Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot edit components in nested Accordion #2285

Closed
tavleensingh4 opened this issue Aug 29, 2022 · 7 comments · Fixed by #2408
Closed

Cannot edit components in nested Accordion #2285

tavleensingh4 opened this issue Aug 29, 2022 · 7 comments · Fixed by #2408
Labels
bug Unexpected problem or unintended behavior that impairs normal functioning of the product. done
Milestone
2.22.0

Comments

@tavleensingh4
Copy link

tavleensingh4 commented Aug 29, 2022 •
edited

Bug Report

Current Behavior

  • Drop an accordion component on a page
  • Add a few components in the accordion. Add another accordion inside the first accordion
  • Re-arrange the items inside the inner accordion from the panel control
  • The items inside the inner accordion are not editable except the first one

If an accordion component has another accordion inside it, then the items of the inner accordion are not editable after re-arranging them from the panel control

Expected behavior/code
User should be able to select/edit the items inside the inner accordion.

Environment

  • AEM version 6.5 SP 6.5.13
  • Core Components version 2.20.8
  • JRE version 11

accordion
@bpauli
Copy link
Contributor

bpauli commented Sep 1, 2022

Hi @tavleensingh4, can you please provide a screen recording of this issue as I was not able to reproduce it? Thanks!

@bpauli bpauli added the needs-clarification Unconfirmed or requires further discussion. label Sep 12, 2022
@bpauli
Copy link
Contributor

bpauli commented Sep 12, 2022

@tavleensingh4 Can you please provide an update or can I close this issue? Thanks!

@tavleensingh4
Copy link
Author

@bpauli Please refer the attached screen recording
screen-capture.zip
Thanks.

@bpauli bpauli added bug Unexpected problem or unintended behavior that impairs normal functioning of the product. and removed needs-clarification Unconfirmed or requires further discussion. labels Sep 15, 2022
@bpauli
Copy link
Contributor

bpauli commented Sep 15, 2022

@tavleensingh4 Thank you for the recording. I was now also able to reproduce the issue. It's a bug in the editor we need to tackle.

@bpauli
Copy link
Contributor

bpauli commented Sep 15, 2022

@adobe export issue to Jira project SITES as Bug

@github-jira-sync-bot
Copy link
Collaborator

✅ Jira issue SITES-8078 is successfully created for this GitHub issue.

@vladbailescu
Copy link
Member

To work around this bug one can (temporarily) make all the child/inner accordion tabs/panels exapanded:
image
this will allow editing of all child items:
image

@vladbailescu vladbailescu changed the title Authoring Issue with Accordion Cannot edit components in nested Accordion Dec 19, 2022
@github-jira-sync-bot github-jira-sync-bot added the in progress Work is underway on implementing this fix or enhancement. label Dec 19, 2022
vladbailescu added a commit that referenced this issue Dec 19, 2022
@vladbailescu
Cannot edit components in nested Accordion
6483954 
* Added parent accordion id to active selector, otherwise the first panel in nested accordion will always be returned active (since it's already in an active panel in the parent accordion)

Fixes #2285
@vladbailescu vladbailescu mentioned this issue Dec 19, 2022
Merged
@github-jira-sync-bot github-jira-sync-bot added in review and removed in progress Work is underway on implementing this fix or enhancement. labels Dec 19, 2022
@vladbailescu vladbailescu added this to the 2.21.4 milestone Dec 19, 2022
bpauli pushed a commit that referenced this issue Dec 20, 2022
@vladbailescu
Cannot edit components in nested Accordion (#2408)
6252e40 
* Added parent accordion id to active selector, otherwise the first panel in nested accordion will always be returned active (since it's already in an active panel in the parent accordion)

Fixes #2285
@github-jira-sync-bot github-jira-sync-bot added to verify issue is resolved, waiting to be tested and verified done and removed in review to verify issue is resolved, waiting to be tested and verified labels Dec 20, 2022
@bpauli bpauli modified the milestones: 2.21.4, 2.22.0 Feb 9, 2023
@SashankaSaladi SashankaSaladi mentioned this issue Feb 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Unexpected problem or unintended behavior that impairs normal functioning of the product. done
Projects
None yet
Milestone
2.22.0
Development

Successfully merging a pull request may close this issue.

Cannot edit components in nested Accordion adobe/aem-core-wcm-components
4 participants
@bpauli @vladbailescu @tavleensingh4 @github-jira-sync-bot