-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tabs][Carousel] The Json export doesn't work properly for nested Tabs and Carousels #298
Comments
We should first define how the JSON should look like. I see the following options: Option 1 We introduce a The JSON would look as follows:
Advantages:
Disadvantages:
Option 2 We introduce a specific node for the tab item which:
The JCR structure would look as follows:
The JSON would look as follows:
Advantages:
Disadvantages:
WDYT? |
Another option would be to wrap the exported items in a class that adds the extra properties we need and inline/unwrap the original exported model. The JSON would look like
We could use @JsonUnwrapped to inline wrapped model properties. |
TLDR: I'm for Option 3. Option 1
Option 2
Option 3 Finally, we should also apply the same architectural concept to the Carousel component. |
The following commit implements option 3 with item specific properties ( |
…s and Carousels #298 * Updated Tabs and Carousel to implement ContainerExporter
…s and Carousels #298 - panel select, only append subtitle it available
…s and Carousels #298 - panel select, only append subtitle it available
…s and Carousels #298 * Updated Tabs and Carousel to also adapt to ContainerExporter
…s and Carousels #298 - panel select, only append subtitle it available
The items elements are not exported properly in Json when having nested tabs.
(CQ-4253492)
The text was updated successfully, but these errors were encountered: