Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Carousel] Disable autoplay related fields when autoplay is disabled (edit dialog) #361

Closed
richardhand opened this issue Oct 31, 2018 · 1 comment
Closed

[Carousel] Disable autoplay related fields when autoplay is disabled (edit dialog) #361

richardhand opened this issue Oct 31, 2018 · 1 comment
Labels
enhancement New feature, or improvement to an existing feature.
Milestone
2.2.2

Comments

@richardhand
Copy link
Contributor

richardhand commented Oct 31, 2018 •
edited
Loading

In the Properties tab of the Edit dialog of the Carousel component, when "Automatically transition slides" is unchecked, the related autoplay fields ("Transition Delay" and "Disable automatic pause on hover" fields should be disabled and/or hidden.

CQ-4255198
@richardhand richardhand added the enhancement New feature, or improvement to an existing feature. label Oct 31, 2018
@richardhand richardhand added this to the 2.2.2 milestone Oct 31, 2018
@richardhand richardhand mentioned this issue Oct 31, 2018
Merged
@richardhand richardhand changed the title [Carousel] Disable "Transition Delay" when automatic transition is disabled (edit dialog) [Carousel] Disable autoplay related fields when autoplay is disabled (edit dialog) Nov 1, 2018
richardhand added a commit that referenced this issue Nov 6, 2018
@richardhand
#326 #327 #361 [Carousel] Pause/play enhancements (#358)
0c21fb9 
- adds pause and play buttons and JS handling
- adds ability to disable auto pause of carousel on hover
- utilises page visibility API for pausing autoplay when document is hidden
- conditionally hides autoplay dialog fields
- simplifies basic styling
vladbailescu pushed a commit that referenced this issue Nov 7, 2018
@richardhand @vladbailescu
#326 #327 #361 [Carousel] Pause/play enhancements (#358)
0f03b2b 
- adds pause and play buttons and JS handling
- adds ability to disable auto pause of carousel on hover
- utilises page visibility API for pausing autoplay when document is hidden
- conditionally hides autoplay dialog fields
- simplifies basic styling
@richardhand
Copy link
Contributor Author

This was fixed with the merge of #358 and is on master. It will be available in the upcoming 2.2.2 release.

richardhand added a commit that referenced this issue Nov 7, 2018
@richardhand
#326 #327 #361 [Carousel] Pause/play enhancements
e46c2a6 
- @trivial - match exact action text
richardhand added a commit that referenced this issue Nov 7, 2018
@richardhand
#326 #327 #361 [Carousel] Pause/play enhancements
9dd4a76 
- @trivial - match exact action text
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature, or improvement to an existing feature.
Projects
None yet
Milestone
2.2.2
Development

No branches or pull requests
1 participant
@richardhand