Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Library] Refactor to reflect component groups #1862

Merged
merged 1 commit into from Oct 11, 2021

Conversation

virresh
Copy link
Contributor

@virresh virresh commented Oct 6, 2021

Have also updated node name to avoid conflict with
AEM Forms Container Component teaser node and
Forms and Communications Portal Sidebar Node

Fixes #1484

Q                       A
Fixed Issues? Fixes #1484
Patch: Bug Fix? No
Minor: New Feature? No
Major: Breaking Change? No
Tests Added + Pass? Yes
Documentation Provided Yes (code comments and or markdown)
Any Dependency Changes? No
License Apache License, Version 2.0

Refactoring of the component library examples page as per instructions given on the original issue. Some additional changes done to prevent conflicts with forms nodes.

Screenshot of re-factored library:
image

image

image

image

Have also updated node name to avoid conflict with
AEM Forms Container Component teaser node and
Forms and Communications Portal Sidebar Node

Fixes adobe#1484
@sonarcloud
Copy link

sonarcloud bot commented Oct 6, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
3.2% 3.2% Duplication

@codecov
Copy link

codecov bot commented Oct 6, 2021

Codecov Report

Merging #1862 (e014dd6) into development (62d3f19) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             development    #1862   +/-   ##
==============================================
  Coverage          86.59%   86.59%           
  Complexity          2292     2292           
==============================================
  Files                210      210           
  Lines               6097     6097           
  Branches             926      926           
==============================================
  Hits                5280     5280           
  Misses               332      332           
  Partials             485      485           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62d3f19...e014dd6. Read the comment docs.

@virresh
Copy link
Contributor Author

virresh commented Oct 7, 2021

While working on this issue, I noticed https://www.adobe.com/go/aem_cmp_tech_languagenavigation_v2 url is invalid and does not work, other than that all other URLs seem to be working fine.

I don't know how to track/modify adobe.com/go urls that point to specific examples, please let me know if there's a place I can modify them in this repo.

Also another point I am not sure about is the text for "Social Media Sharing" on sidebar. I've kept it the same as the text on front page teaser for now, please let me know if this needs to be changed.

@gabrielwalt @vladbailescu please review

@rismehta
Copy link
Contributor

rismehta commented Oct 8, 2021

@vladbailescu @gabrielwalt Can you review this ?

@jckautzmann jckautzmann merged commit 0876a2a into adobe:development Oct 11, 2021
@jckautzmann
Copy link
Contributor

Thx @virresh for your PR! I fixed the go URLs in a separate PR [0] so that we can merge and close this one.

[0] #1868

@virresh virresh deleted the example-refactoring branch October 13, 2021 05:05
virresh added a commit to virresh/aem-core-forms-components that referenced this pull request Oct 13, 2021
This is accompanying changes to sites core wcm examples
See PR adobe/aem-core-wcm-components#1862
bpauli added a commit that referenced this pull request Jan 25, 2022
fix broken internal links regression introduced with #1862
bpauli added a commit that referenced this pull request Jan 26, 2022
fix broken internal links regression introduced with #1862
rismehta pushed a commit to adobe/aem-core-forms-components that referenced this pull request May 12, 2022
This is accompanying changes to sites core wcm examples
See PR adobe/aem-core-wcm-components#1862
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants