New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Library] Refactor to reflect component groups #1862
Conversation
Have also updated node name to avoid conflict with AEM Forms Container Component teaser node and Forms and Communications Portal Sidebar Node Fixes adobe#1484
SonarCloud Quality Gate failed. 0 Bugs No Coverage information |
Codecov Report
@@ Coverage Diff @@
## development #1862 +/- ##
==============================================
Coverage 86.59% 86.59%
Complexity 2292 2292
==============================================
Files 210 210
Lines 6097 6097
Branches 926 926
==============================================
Hits 5280 5280
Misses 332 332
Partials 485 485 Continue to review full report at Codecov.
|
While working on this issue, I noticed https://www.adobe.com/go/aem_cmp_tech_languagenavigation_v2 url is invalid and does not work, other than that all other URLs seem to be working fine. I don't know how to track/modify adobe.com/go urls that point to specific examples, please let me know if there's a place I can modify them in this repo. Also another point I am not sure about is the text for "Social Media Sharing" on sidebar. I've kept it the same as the text on front page teaser for now, please let me know if this needs to be changed. @gabrielwalt @vladbailescu please review |
@vladbailescu @gabrielwalt Can you review this ? |
This is accompanying changes to sites core wcm examples See PR adobe/aem-core-wcm-components#1862
fix broken internal links regression introduced with #1862
fix broken internal links regression introduced with #1862
This is accompanying changes to sites core wcm examples See PR adobe/aem-core-wcm-components#1862
Have also updated node name to avoid conflict with
AEM Forms Container Component teaser node and
Forms and Communications Portal Sidebar Node
Fixes #1484
Refactoring of the component library examples page as per instructions given on the original issue. Some additional changes done to prevent conflicts with forms nodes.
Screenshot of re-factored library: