Reduce repository access #2447

joerghoh · 2023-02-11T17:51:53Z

Q	A
Fixed Issues?
Patch: Bug Fix?
Minor: New Feature?
Major: Breaking Change?
Tests Added + Pass?	Yes
Documentation Provided	Yes (code comments and or markdown)
Any Dependency Changes?	No
License	Apache License, Version 2.0

Improve SlingModels to calculate values more lazily to avoid costly repository access for values, which might not be used at all.

codecov · 2023-02-11T17:53:57Z

Codecov Report

Attention: Patch coverage is 82.50000% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 87.21%. Comparing base (f28f5fd) to head (adde00b).

Files	Patch %	Lines
...m/core/components/internal/models/v1/PageImpl.java	82.75%	2 Missing and 3 partials ⚠️
...obe/cq/wcm/core/components/internal/LazyValue.java	75.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #2447      +/-   ##
============================================
- Coverage     87.28%   87.21%   -0.08%     
- Complexity     2659     2665       +6     
============================================
  Files           232      233       +1     
  Lines          7110     7123      +13     
  Branches       1084     1085       +1     
============================================
+ Hits           6206     6212       +6     
- Misses          359      362       +3     
- Partials        545      549       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

bundles/core/src/main/java/com/adobe/cq/wcm/core/components/internal/LazyValue.java

royteeuwen · 2023-02-24T09:40:58Z

bundles/core/src/main/java/com/adobe/cq/wcm/core/components/internal/LazyValue.java

+ ~ See the License for the specific language governing permissions and
+ ~ limitations under the License.
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~*/
+package com.adobe.cq.wcm.core.components.internal;


can this be moved outside of internal so that it can also be used in our proxy classes?

Good point, although this would be an extension of the public API, and so I would like to have it at least discussed here. Will raise that point when this PR has been merged.