LinkImpl: avoid redundant repository lookups #2453
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LinkBuilderImpl does a few lookups in the repository (mostly path-to-resource lookups), which are redundant and can be avoided.
This is the case if the LinkBuilderImpl is already invoked with a linktarget of an asset or a page; there is no need to retrieve the asset/page again from the path of the provided object).
Also in the creation of the linkUrl there is no need to trying to resolve the path back to a page to determine if the ".html" extension should be added, this information is already available.