Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SITES-12764 - [Image] Support for relative crop coordinates #2518

Merged
merged 4 commits into from
Jun 20, 2023

Conversation

bpauli
Copy link
Contributor

@bpauli bpauli commented Jun 1, 2023

  • add support for relative coordinates in the image src for Web Optimized Image Delivery
Q                       A
Fixed Issues? SITES-12764
Patch: Bug Fix? 👍
Minor: New Feature? 👎
Major: Breaking Change? 👎
Tests Added + Pass? Yes
Documentation Provided Yes (code comments and or markdown)
Any Dependency Changes?
License Apache License, Version 2.0

- add support for relative coordinates in the image src for Web Optimized Image Delivery
@bpauli bpauli requested a review from msagolj June 1, 2023 20:04
- get web rendition only in case the crop coordinates are set
@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Merging #2518 (c897b2f) into main (28efbf8) will decrease coverage by 0.06%.
The diff coverage is 80.00%.

❗ Current head c897b2f differs from pull request most recent head f8dbbc6. Consider uploading reports for the commit f8dbbc6 to get more accurate results

@@             Coverage Diff              @@
##               main    #2518      +/-   ##
============================================
- Coverage     87.25%   87.19%   -0.06%     
- Complexity     2609     2614       +5     
============================================
  Files           229      229              
  Lines          6926     6958      +32     
  Branches       1049     1054       +5     
============================================
+ Hits           6043     6067      +24     
- Misses          354      358       +4     
- Partials        529      533       +4     
Impacted Files Coverage Δ
...nts/internal/helper/image/AssetDeliveryHelper.java 82.70% <80.00%> (-2.45%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Jun 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@bpauli bpauli merged commit 70710ad into main Jun 20, 2023
17 of 18 checks passed
@bpauli bpauli deleted the issue/SITES-12764 branch June 20, 2023 07:37
@LSantha LSantha added this to the 2.23.2 milestone Jul 26, 2023
@LSantha LSantha changed the title [Image] Support for relative crop coordinates SITES-12764 - [Image] Support for relative crop coordinates Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants