SITES-13120 - Image Smart Crop support for remote assets in various Sites core components #2524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2524 +/- ##
============================================
+ Coverage 87.27% 87.31% +0.03%
- Complexity 2623 2645 +22
============================================
Files 229 232 +3
Lines 6986 7063 +77
Branches 1060 1071 +11
============================================
+ Hits 6097 6167 +70
- Misses 358 359 +1
- Partials 531 537 +6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
indra2gurjar
changed the title
…olaris assets picker - WIP)
… dialog image preview - WIP)
…for Polaris assets * removed polarisImage hidden field from Image component edit dialog
- Changed the dependency from com.adobe.cq.ui.commons to optional (will be removed when the service pack will be released)
…for Polaris assets * use fileReference property also for Polaris images * enabled Polaris support for Image component
…for Polaris assets * remove URL params from JCR for Polaris images, they are added on URL rendering
…for Polaris assets * fixed Polaris image rendering in Teaser component
…for Polaris assets * fixing local test runs
…for Polaris assets * fixed TeaserImplTest failure
…for Polaris assets * image rendering improvements
…for Polaris assets * more image rendering improvements
…for Polaris assets * fixed build issue
…for Polaris assets * enabled AEM 6.5 SP 17 * added unit test for TeaserImpl v2 changes
…for Polaris assets * added unit tests for ImageImpl v3 changes
cbogdan0707
reviewed
Jun 27, 2023
..._root/apps/core/wcm/components/image/v3/image/clientlibs/ngdmsmartcrop/js/smartcropaction.js
Outdated
Show resolved
Hide resolved
cbogdan0707
reviewed
Jun 27, 2023
..._root/apps/core/wcm/components/image/v3/image/clientlibs/ngdmsmartcrop/js/smartcropaction.js
Outdated
Show resolved
Hide resolved
cbogdan0707
reviewed
Jun 27, 2023
..._root/apps/core/wcm/components/image/v3/image/clientlibs/ngdmsmartcrop/js/smartcropdialog.js
Outdated
Show resolved
Hide resolved
cbogdan0707
reviewed
Jun 27, 2023
..._root/apps/core/wcm/components/image/v3/image/clientlibs/ngdmsmartcrop/js/smartcropdialog.js
Show resolved
Hide resolved
cbogdan0707
reviewed
Jun 27, 2023
..._root/apps/core/wcm/components/image/v3/image/clientlibs/ngdmsmartcrop/js/smartcropdialog.js
Show resolved
Hide resolved
cbogdan0707
reviewed
Jun 27, 2023
...root/apps/core/wcm/components/image/v3/image/clientlibs/ngdmsmartcrop/js/smartcroppreview.js
Outdated
Show resolved
Hide resolved
cbogdan0707
reviewed
Jun 27, 2023
...root/apps/core/wcm/components/image/v3/image/clientlibs/ngdmsmartcrop/js/smartcroppreview.js
Outdated
Show resolved
Hide resolved
cbogdan0707
reviewed
Jun 27, 2023
...root/apps/core/wcm/components/image/v3/image/clientlibs/ngdmsmartcrop/js/smartcroppreview.js
Outdated
Show resolved
Hide resolved
|
@LSantha @cbogdan0707 I tried incorporating your review feedback. Could you please review? |
cbogdan0707
approved these changes
Jul 3, 2023
LSantha
reviewed
Jul 18, 2023
| @@ -72,7 +72,8 @@ public void testNgdmImage() throws ClientException { | |||
| Assert.assertEquals(1, images.size()); | |||
| Element img = images.first(); | |||
| String imageSource = img.attr("src"); | |||
| Assert.assertEquals("https://testrepository/adobe/dynamicmedia/deliver/urn:aaid:aem:e82c3c87-1453-48f5-844b-1822fb610911/cutfruits.png?width=640&preferwebp=true", imageSource); | |||
| System.out.println(imageSource); | |||
LSantha
approved these changes
Jul 18, 2023
|
@indra2gurjar , nice work. Thank you. |
|
Kudos, SonarCloud Quality Gate passed!
|
LSantha
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding smartcrop functionility to NextGen dynamic media images.
Added a new smartcrop button which will open only when a NGDM image is selected.
On clicking the button, a dialog will open with UI for taking user input for smartcrop aspect ratios and image preview showing the smartcrop.
ngdm-smartcrop.mov