SITES-13771 - Content Fragment List component : Property Name is getting displayed to users rather than Field Label #2546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to users rather than Field Label For multi text field look for cfm-element key or fallback on the default value.
Codecov Report
@@ Coverage Diff @@
## main #2546 +/- ##
=========================================
Coverage 87.22% 87.22%
- Complexity 2615 2616 +1
=========================================
Files 229 229
Lines 6972 6974 +2
Branches 1054 1055 +1
=========================================
+ Hits 6081 6083 +2
Misses 358 358
Partials 533 533
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Kudos, SonarCloud Quality Gate passed!
|
cristianbrande
approved these changes
Jul 14, 2023
LSantha
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tries to get the multi text field from "cfm-element" key rather than from the fieldLabel key and falls back on the default value in case is doesn't find anything.