SITES-13898 - [AEMaaCS] The Accordion/Carousel/Tabs Component cannot delete dialog item after moving #2547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
myronenko
commented
Jul 14, 2023
•
myronenko
commented
- Fixed moved item deletion for the Accordion/Carousel/Tabs components
| Q | A |
|---|---|
| Fixed Issues? | SITES-13898 |
| Patch: Bug Fix? | Bug Fix |
| Minor: New Feature? | |
| Major: Breaking Change? | |
| Tests Added + Pass? | Yes |
| Documentation Provided | Yes (code comments) |
| Any Dependency Changes? | |
| License | Apache License, Version 2.0 |
Codecov Report
@@ Coverage Diff @@
## main #2547 +/- ##
=========================================
Coverage 87.22% 87.22%
Complexity 2616 2616
=========================================
Files 229 229
Lines 6974 6974
Branches 1055 1055
=========================================
Hits 6083 6083
Misses 358 358
Partials 533 533 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cbogdan0707
reviewed
Jul 14, 2023
...nents/commons/editor/dialog/childreneditor/v1/childreneditor/clientlibs/js/childreneditor.js
Outdated
Show resolved
Hide resolved
cbogdan0707
reviewed
Jul 14, 2023
...nents/commons/editor/dialog/childreneditor/v1/childreneditor/clientlibs/js/childreneditor.js
Outdated
Show resolved
Hide resolved
cbogdan0707
reviewed
Jul 14, 2023
...nents/commons/editor/dialog/childreneditor/v1/childreneditor/clientlibs/js/childreneditor.js
Outdated
Show resolved
Hide resolved
cbogdan0707
reviewed
Jul 14, 2023
| @@ -252,25 +252,23 @@ | |||
| } | |||
|
|
|||
| Coral.commons.ready(that._elements.self, function(item) { | |||
| // As a reordering of the multifield also triggers the coral-collection:remove event we have to add | |||
There was a problem hiding this comment.
I think since that._elements.self is referenced multiple times, could probably be stored as a const and used in all the other places, but this is more a nitpick
|
Kudos, SonarCloud Quality Gate passed!
|
cbogdan0707
approved these changes
Jul 17, 2023
LSantha
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.