SITES-15109 - RFH - Applying Async in clientlibraries not working on customer instance #2570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
LSantha
commented
Aug 10, 2023
•
LSantha
commented
- added request attribute based injection for categories and resourceTypes fields as a safety mechanism to reduce the risk of unintended injections on these two fields
- updated unit tests
| Q | A |
|---|---|
| Fixed Issues? | SITES-15109 , #1808 |
| Patch: Bug Fix? | Yes |
| Minor: New Feature? | No |
| Major: Breaking Change? | No |
| Tests Added + Pass? | Yes |
| Documentation Provided | Yes (code comments and or markdown) |
| Any Dependency Changes? | No |
| License | Apache License, Version 2.0 |
…customer instance * added request attribute based injection for categories and resourceTypes fields as a safety mechanism to reduce the risk of unintended injections on these two fields * updated unit tests
Codecov Report
@@ Coverage Diff @@
## main #2570 +/- ##
=========================================
Coverage 87.33% 87.33%
- Complexity 2646 2648 +2
=========================================
Files 232 232
Lines 7072 7076 +4
Branches 1071 1073 +2
=========================================
+ Hits 6176 6180 +4
Misses 359 359
Partials 537 537
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
vladbailescu
approved these changes
Aug 16, 2023
cbogdan0707
approved these changes
Aug 17, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.