Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2606] Fixed Non-deterministic behavior of HashSet that might fail the test ClientLibrariesImplTest #2621

Merged
merged 6 commits into from Dec 27, 2023
Merged

[2606] Fixed Non-deterministic behavior of HashSet that might fail the test ClientLibrariesImplTest #2621

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ded99f6
Fixed flaky test
SaaiVenkat Oct 18, 2023
ff5528c
Merge branch 'main' of https://github.com/SaaiVenkat/aem-core-wcm-com…
SaaiVenkat Nov 1, 2023
40e7621
Changed HashSet to LinkedHashSet in ClientLibrariesImpl
SaaiVenkat Nov 1, 2023
7718d46
Removed unused import HashSet
SaaiVenkat Nov 12, 2023
b53dd41
Merge branch 'main' into improvement/fix-flaky-test-ClientLibrariesIm…
SaaiVenkat Nov 29, 2023
5cab8af
Merge branch 'main' into improvement/fix-flaky-test-ClientLibrariesIm…
SaaiVenkat Dec 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions ...rc/main/java/com/adobe/cq/wcm/core/components/internal/models/v1/ClientLibrariesImpl.java
View file
Open in desktop
Expand Up @@ -22,7 +22,6 @@
import java.util.Arrays;
import java.util.Collection;
import java.util.Collections;
import java.util.HashSet;
import java.util.LinkedHashSet;
import java.util.List;
import java.util.Map;
Expand Down Expand Up @@ -297,7 +296,7 @@ private String getInline(LibraryType libraryType) {
@NotNull
protected Set<String> getCategoriesFromComponents() {
try (ResourceResolver resourceResolver = resolverFactory.getServiceResourceResolver(Collections.singletonMap(ResourceResolverFactory.SUBSERVICE, COMPONENTS_SERVICE))) {
Set<String> categories = new HashSet<>();
Set<String> categories = new LinkedHashSet<>();
for (ClientLibrary library : this.getAllClientLibraries(resourceResolver)) {
for (String category : library.getCategories()) {
if (pattern == null || pattern.matcher(category).matches()) {
Expand Down