Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the maven group across 2 directories with 1 update #2669

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 6, 2024

Bumps the maven group with 1 update in the /bundles/core directory: org.apache.sling:org.apache.sling.api.

Updates org.apache.sling:org.apache.sling.api from 2.22.0 to 2.25.4

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps the maven group with 1 update in the /bundles/core directory: org.apache.sling:org.apache.sling.api.


Updates `org.apache.sling:org.apache.sling.api` from 2.22.0 to 2.25.4

---
updated-dependencies:
- dependency-name: org.apache.sling:org.apache.sling.api
  dependency-type: direct:development
  dependency-group: maven-security-group
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Feb 6, 2024
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.17%. Comparing base (23504e0) to head (c66b2a8).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2669   +/-   ##
=========================================
  Coverage     87.17%   87.17%           
  Complexity     2668     2668           
=========================================
  Files           233      233           
  Lines          7128     7128           
  Branches       1090     1090           
=========================================
  Hits           6214     6214           
  Misses          363      363           
  Partials        551      551           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LSantha
Copy link
Contributor

LSantha commented Mar 1, 2024

SP 21 is still at 2.22.0-B002 .

@LSantha LSantha closed this Mar 1, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 1, 2024

This pull request was built based on a group rule. Closing it will not ignore any of these versions in future pull requests.

@dependabot dependabot bot deleted the dependabot/maven/bundles/core/maven-security-group-6523ba2a3a branch March 1, 2024 20:11
@vladbailescu vladbailescu restored the dependabot/maven/bundles/core/maven-security-group-6523ba2a3a branch March 2, 2024 08:44
@vladbailescu vladbailescu reopened this Mar 2, 2024
Copy link

sonarcloud bot commented Mar 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@vladbailescu
Copy link
Member

vladbailescu commented Mar 2, 2024

Since this is test scope, we can consider updating the dependency even if SP21 does not yet include the updated Sling API.

@vladbailescu vladbailescu merged commit 2226de3 into main Mar 2, 2024
15 checks passed
@vladbailescu vladbailescu deleted the dependabot/maven/bundles/core/maven-security-group-6523ba2a3a branch March 2, 2024 09:17
@LSantha LSantha added this to the 2.25.0 milestone Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code verified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants