SITES-20101 - Ignored defaultValue in numberfield of component dialogs #2685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
LSantha
commented
Feb 27, 2024
LSantha
commented
- remove defaultValue of granite/ui/components/coral/foundation/form/numberfield in component dialogs
| Q | A |
|---|---|
| Fixed Issues? | SITES-20101 |
| Patch: Bug Fix? | Yes |
| Minor: New Feature? | |
| Major: Breaking Change? | |
| Tests Added + Pass? | Yes |
| Documentation Provided | Yes (code comments and or markdown) |
| Any Dependency Changes? | |
| License | Apache License, Version 2.0 |
* remove defaultValue of granite/ui/components/coral/foundation/form/numberfield in component dialogs
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2685 +/- ##
=========================================
Coverage 87.21% 87.21%
Complexity 2665 2665
=========================================
Files 233 233
Lines 7123 7123
Branches 1085 1085
=========================================
Hits 6212 6212
Misses 362 362
Partials 549 549 ☔ View full report in Codecov by Sentry. |
myronenko
approved these changes
Feb 28, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.