Sites 19919 1 #2694
Merged
Sites 19919 1 #2694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rnal redirect Jira: https://jira.corp.adobe.com/browse/SITES-19919 There are 3 distinct cases: * internal page list item * internal page list item with external redirect * external page list item First and third cases were handled correctly But in the second case the page was treated as external (3rd case) leading to the missing teaser image The current fix makes sure that in the 2nd case the page is considered internal just like in the 1st case
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2694 +/- ##
============================================
- Coverage 87.17% 87.16% -0.02%
Complexity 2668 2668
============================================
Files 233 233
Lines 7128 7128
Branches 1090 1090
============================================
- Hits 6214 6213 -1
Misses 363 363
- Partials 551 552 +1 ☔ View full report in Codecov by Sentry. |
alexandru-stancioiu
approved these changes
Mar 15, 2024
Myronenko
reviewed
Mar 18, 2024
testing/it/http/src/test/java/com/adobe/cq/wcm/core/components/it/http/ListIT.java
Outdated
Show resolved
Hide resolved
|
LSantha
approved these changes
Mar 18, 2024
|
Looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1, Fixes #2