Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SITES-21038] Core Tabs Component Accessibility Issue - Invalid ARIA attribute value #2713

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

YahorC
Copy link
Contributor

@YahorC YahorC commented Apr 4, 2024

Updating tab panel id value, to have connection with tab item aria-controls value, for passing lighthouse report accessibility successfully

Q                       A
Fixed Issues? Fixes #1, Fixes #2
Patch: Bug Fix?
Minor: New Feature?
Major: Breaking Change?
Tests Added + Pass? Yes
Documentation Provided Yes (code comments and or markdown)
Any Dependency Changes?
License Apache License, Version 2.0

@YahorC YahorC requested a review from a team April 4, 2024 09:00
Copy link

sonarcloud bot commented Apr 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.16%. Comparing base (9e182f4) to head (892492a).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2713   +/-   ##
=========================================
  Coverage     87.16%   87.16%           
  Complexity     2668     2668           
=========================================
  Files           233      233           
  Lines          7128     7128           
  Branches       1090     1090           
=========================================
  Hits           6213     6213           
  Misses          363      363           
  Partials        552      552           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@YahorC YahorC merged commit 7267867 into main Apr 5, 2024
15 checks passed
@YahorC YahorC deleted the SITES-21038 branch April 5, 2024 08:04
@vladbailescu vladbailescu added this to the 2.24.6 milestone Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants