Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SITES-21127 - [Core Components] Remove usages of Commons Collections 3 #2722

Merged
merged 3 commits into from
Apr 16, 2024
Merged

SITES-21127 - [Core Components] Remove usages of Commons Collections 3 #2722

merged 3 commits into from
Apr 16, 2024

Conversation

vladbailescu
Copy link
Member

  • Replaced Commons Collections 3 with 4

@LSantha
Copy link
Contributor

LSantha commented Apr 11, 2024 •
edited
Loading

@vladbailescu , can we remove it also from the POMs like here?

aem-core-wcm-components/bundles/core/pom.xml

Lines 370 to 373 in 6907e23

<dependency>
<groupId>commons-collections</groupId>
<artifactId>commons-collections</artifactId>
</dependency>

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@vladbailescu
Copy link
Member Author

@LSantha , removed old dependencies in 2b6ca39

@vladbailescu vladbailescu merged commit e24d604 into main Apr 16, 2024
15 of 16 checks passed
@vladbailescu vladbailescu deleted the issue/SITES-21127 branch April 16, 2024 14:13
@LSantha LSantha added this to the 2.25.0 milestone Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myronenko myronenko myronenko approved these changes

@andreeadracea andreeadracea andreeadracea approved these changes

@RaduADumitru RaduADumitru RaduADumitru approved these changes

Assignees
No one assigned
Labels
verified
Projects
None yet
Milestone
2.25.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vladbailescu @LSantha @myronenko @andreeadracea @RaduADumitru