Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Button] Improve icon-only button #2726

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

renow-luxembourg
Copy link
Contributor

@renow-luxembourg renow-luxembourg commented Apr 16, 2024

Feature Request

Current Behavior :
In button component with svg only content, on mousehover there are no way to get a visible label.
It's ok for known icons like the "burger menu" or the "magnifying glass", but it can be difficult for little-recognized icons.
It's also ok for people using screen reader because an aria-label attribute can be specified on the element.

Expected behavior/code :
To get a visible indication on hover (like the browser hover tooltip) for icon only button.

Environment

Possible Solution :
Add a title attribute on the

element. It have to be equal to the aria-label attribute value (to avoid a double vocalisation by the screen reader).
I choose to add it by default when there isn't text content in the button. An alternative is to add a checkbox in the cq_dialog

Copy link

sonarcloud bot commented Apr 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@vladbailescu vladbailescu added this to the 2.25.0 milestone Apr 18, 2024
@LSantha LSantha merged commit f861c90 into adobe:main Apr 26, 2024
8 of 11 checks passed
@renow-luxembourg
Copy link
Contributor Author

Adobe CLA filled and signed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants