Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SITES-21048 Default values for fields in image component dialog are not considered after drag & drop of asset on image component #2735

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

UladzimirLitvinchukAdobe
Copy link
Contributor

@UladzimirLitvinchukAdobe UladzimirLitvinchukAdobe commented Apr 23, 2024

ignore freshness for checkbox isDecorative, disableLazyLoading, titleValueFromDAM and displayPopupTitle in Image v3 edit dialog
ignore freshness for checkbox isDecorative in Image v2 edit dialog

Q                       A
Fixed Issues? SITES-21048
Patch: Bug Fix? Yes
Minor: New Feature? No
Major: Breaking Change? No
Tests Added + Pass? Yes
Documentation Provided No needs
Any Dependency Changes? No
License Apache License, Version 2.0

Original issue from the client was
Summary
The customer is experiencing an issue where default values for dialog fields in an image component are not being retained after a drag & drop operation or post-processing by a SlingPostProcessor. This behavior is inconsistent and impacts content authoring workflows, as default values are expected to be applied consistently.

The fix: add specific property - ignore freshness- to the Image v2 andv3 component. This fix align the behaviour before and after drag and drop action.

…ot considered after drag & drop of asset on image component
…ot considered after drag & drop of asset on image component. Image v2 update
Copy link

sonarcloud bot commented Apr 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@LSantha LSantha added this to the 2.25.0 milestone Apr 25, 2024
@LSantha LSantha merged commit 71f8a55 into adobe:main Apr 26, 2024
11 checks passed
stefanseifert added a commit to wcm-io/io.wcm.wcm.core.components that referenced this pull request May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants