Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync dispatcher immutable files with Dispatcher SDK and image v2.0.166 #398

Merged

Conversation

krystiannowak
Copy link
Contributor

sync dispatcher immutable files with Dispatcher SDK and image v2.0.166

Description

Since the previous sync of dispatcher immutable files with Dispatcher SDK and image was from version 2.0.120 in August 2022 and AEM CS releases already progressed further, including dispatcher image and SDK tooling containing newer files, it resulted already in customer using latest public AEM CS releases being out of sync and reporting issues like adobe/aem-project-archetype#1043

Hence we propose to sync those files with the ones from the latest Dispatcher SDK and image v2.0.166 in order for validation scripts not to fail in immutable files compatibility check step as described in https://experienceleague.adobe.com/docs/experience-manager-cloud-service/content/implementing/content-delivery/validation-debug.html?lang=en#third-phase

Related Issue

Motivation and Context

Not to fail immutable files validation step described in https://experienceleague.adobe.com/docs/experience-manager-cloud-service/content/implementing/content-delivery/validation-debug.html?lang=en#third-phase when using Dispatcher SDK tooling from the latest AEM CS releases.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@krystiannowak
Copy link
Contributor Author

krystiannowak commented Feb 21, 2023

@SachinMali @davidjgonzalez @vladbailescu @gknobloch The changes are currently in Archetype develop via adobe/aem-project-archetype#1045 and will be in Archetype 41 (next to be released) - please review as well

@davidjgonzalez
Copy link
Contributor

@krystiannowak can you re-raise this when 41 is released? WKND stays current to the state of the latest released software (not pre-release, as this is confusing to users that compare their projects using/made from the latest against WKND and see deltas)

@davidjgonzalez davidjgonzalez marked this pull request as draft February 23, 2023 14:41
@krystiannowak
Copy link
Contributor Author

@davidjgonzalez ok, so since there are no further sync planned for now to Archetype (until 41 is released) we can have it in draft mode, so I can undraft it when 41 is out (as I am not sure what are current Archetype 41 release plans). But if there are any dispatcher config immutable files further sync, I can also propagate them into this PR (e.g. if some other AEM CS release with even newer Dispatcher SDK tooling and dispatcher-publish image is to be released sooner than Archetype).

Hope it works for you?

/cc: @froesef

@krystiannowak
Copy link
Contributor Author

@davidjgonzalez Supposedly now Archetype 41 is being cut, containing that change https://github.com/adobe/aem-project-archetype/milestone/34?closed=1

@davidjgonzalez
Copy link
Contributor

@krystiannowak i don't see 41 released yet. Any idea if the release was cancelled?

@krystiannowak
Copy link
Contributor Author

@davidjgonzalez
Copy link
Contributor

@krystiannowak that link 404's - did they rollback the release?

@krystiannowak
Copy link
Contributor Author

@SachinMali
Copy link
Contributor

@krystiannowak Did anyone cut the release, cause I still see 40 on the https://github.com/adobe/aem-project-archetype/releases unless it's getting published, if so once published we should be good for merge.

@krystiannowak
Copy link
Contributor Author

krystiannowak commented Mar 3, 2023

@SachinMali It's still in Draft by @barshat7

/cc: @vladbailescu

@krystiannowak
Copy link
Contributor Author

krystiannowak commented Mar 4, 2023

@krystiannowak krystiannowak marked this pull request as ready for review March 4, 2023 10:30
@SachinMali SachinMali merged commit fafc483 into adobe:main Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants