Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for paginated query results #25

Closed
bdelacretaz opened this issue Jun 9, 2021 · 2 comments · Fixed by #44
Closed

Support for paginated query results #25

bdelacretaz opened this issue Jun 9, 2021 · 2 comments · Fixed by #44

Comments

@bdelacretaz
Copy link
Contributor

The Apache Sling GraphQL Core module, which provides GraphQL support for AEM, now supports paginated result sets following the Relay Connections spec, see https://github.com/apache/sling-org-apache-sling-graphql-core/#result-set-pagination-using-the-connection-and-fetcher-directives . The oneSchemaQuery example there shows a typical response.

For now, that module only supports cursor-based "infinite scroll" style pagination, where you can only move forward in the result set.

It would be nice to support this in the client, with an API that makes the result set appear continuous, while making additional queries as needed to acquire the data. A callback on each such query comes to mind as a way to allow the client to keep track of progress and optionally stop before the end of the result set if desired.
@bdelacretaz bdelacretaz mentioned this issue Jun 9, 2021
Closed
@bdelacretaz
Copy link
Contributor Author

adobe/aem-headless-client-java#4 is the same feature request for the Java client.

@gknobloch gknobloch added the parking Parking Lot label Jun 23, 2021
easingthemes added a commit that referenced this issue Mar 14, 2023
@easingthemes
#25 add query builder
8719e4f
easingthemes added a commit that referenced this issue Mar 14, 2023
@easingthemes
#25 add paginated query suport
5dc358f
@easingthemes easingthemes mentioned this issue Mar 14, 2023
Merged
easingthemes added a commit that referenced this issue Mar 14, 2023
@easingthemes
#25 lint fixes
a8f77ed
easingthemes added a commit that referenced this issue Mar 14, 2023
@easingthemes
#25 add default empty args
00d4b23
easingthemes added a commit that referenced this issue Mar 14, 2023
@easingthemes
#25 add jsdocs
da823af
easingthemes added a commit that referenced this issue Mar 14, 2023
@easingthemes
#25 check required params
cfb682b
easingthemes added a commit that referenced this issue Mar 14, 2023
@easingthemes
#25 throw if required param missing
90dc9c4
easingthemes added a commit that referenced this issue Mar 14, 2023
@easingthemes
#25 split large method
9c22f02
easingthemes added a commit that referenced this issue Mar 14, 2023
@easingthemes
#25 fix object to args string
3ea8e06
easingthemes added a commit that referenced this issue Mar 14, 2023
@easingthemes
#25 move args update in the loop
20332d1
easingthemes added a commit that referenced this issue Mar 14, 2023
@easingthemes
#25 update offset
335ed17
easingthemes added a commit that referenced this issue Mar 14, 2023
@easingthemes
#25 update pagingArgs
aa5f2dc
easingthemes added a commit that referenced this issue Mar 14, 2023
@easingthemes
#25 check page size
00551b4
easingthemes added a commit that referenced this issue Mar 14, 2023
@easingthemes
#25 fix string as a param val
767b18a
easingthemes added a commit that referenced this issue Mar 14, 2023
@easingthemes
#25 fix string as a param val
ee52188
easingthemes added a commit that referenced this issue Mar 14, 2023
@easingthemes
#25 check page size
85f27db
easingthemes added a commit that referenced this issue Mar 14, 2023
@easingthemes
#25 ok response with errors data
06efd4e
easingthemes added a commit that referenced this issue Mar 15, 2023
@easingthemes
#25 update docs
8e5ce4a
easingthemes added a commit that referenced this issue Mar 15, 2023
@easingthemes
#25 remove loop break
71e3c49
easingthemes added a commit that referenced this issue Mar 15, 2023
@easingthemes
#25 add possibility to loop all
f641ee1
easingthemes added a commit that referenced this issue Mar 15, 2023
@easingthemes
#25 update docs
456c1f1
easingthemes added a commit that referenced this issue Mar 15, 2023
@easingthemes
#25 add unit tests
8352f49
easingthemes added a commit that referenced this issue Mar 15, 2023
@easingthemes
#25 add jsdocs and more examples
da821e8
easingthemes added a commit that referenced this issue Mar 15, 2023
@easingthemes
#25 rename and reorder methods
f4a2d91
easingthemes added a commit that referenced this issue Mar 15, 2023
@easingthemes
#25 update docs
83f28a2
easingthemes added a commit that referenced this issue Mar 15, 2023
@easingthemes
#25 move static methods to utils
e846b0a
easingthemes added a commit that referenced this issue Mar 15, 2023
@easingthemes
#25 jsdocs update
79b0bea
easingthemes added a commit that referenced this issue Mar 15, 2023
@easingthemes
#25 add typeDefs to readme
c414f3c
easingthemes added a commit that referenced this issue Mar 15, 2023
@easingthemes
#25 add task to generate TS types definitions
92ca6cc
easingthemes added a commit that referenced this issue Mar 15, 2023
@easingthemes
#25 add generated TS types definitions
2f03aa8
easingthemes added a commit that referenced this issue Mar 15, 2023
@easingthemes
#25 fix helper functions
11899f9
easingthemes added a commit that referenced this issue Mar 15, 2023
@easingthemes
#25 typo fix
8beda7d
easingthemes added a commit that referenced this issue Mar 15, 2023
@easingthemes
#25 prevent empty request
7e157a2
easingthemes added a commit that referenced this issue Mar 15, 2023
@easingthemes
#25 simplify readme examples
3d200b9
easingthemes added a commit that referenced this issue Mar 21, 2023
@easingthemes
feat: #25 add pageSize config
681b08d
easingthemes added a commit that referenced this issue Mar 21, 2023
@easingthemes
fix: #25 update docs
eaf900e
easingthemes added a commit that referenced this issue Mar 23, 2023
@easingthemes
fix: #25 reorder arguments
19e19c5
easingthemes added a commit that referenced this issue Mar 28, 2023
@easingthemes
Feature/#25 pagination (#44)
d2dd391 
* #25 add query builder

* #25 add paginated query suport

* #25 lint fixes

* #25 add default empty args

* #25 add jsdocs

* #25 check required params

* #25 throw if required param missing

* #25 split large method

* #25 fix object to args string

* #25 move args update in the loop

* #25 update offset

* #25 update pagingArgs

* #25 check page size

* #25 fix string as a param val

* #25 fix string as a param val

* #25 check page size

* #25 ok response with errors data

* #25 update docs

* #25 remove loop break

* #25 add possibility to loop all

* #25 update docs

* #25 add unit tests

* #25 add jsdocs and more examples

* #25 rename and reorder methods

* #25 update docs

* #25 move static methods to utils

* #25 jsdocs update

* #25 add typeDefs to readme

* #25 fix helper functions

* #25 typo fix

* #25 prevent empty request

* #25 simplify readme examples

* feat: #25 add pageSize config

* fix: #25 update docs

* fix: #25 reorder arguments
@easingthemes
Copy link
Collaborator

PR merged and package v3.3.0 published to NPM

@easingthemes easingthemes removed the parking Parking Lot label Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/#25 pagination adobe/aem-headless-client-js
3 participants
@bdelacretaz @gknobloch @easingthemes