-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow custom request headers #38
Conversation
@jihuang-adobe What is your use case that requires to set an additional header? Do you have some intermediate infrastructure that requires that header? (I'm asking because potentially it could be better to explicitly provide the functionality over this generic approach, but it depends on if it is very specific to your setup or not) |
Hi @ghenzler. I currently have AEM graphql endpoint behind a proxy. The proxy can potentially take a list of custom headers, so I thought it would be convenient if the AEM Headless Client would accept custom headers as an option. |
to reverse order, to allow single request to override global headers per https://github.com/adobe/aem-headless-client-js/pull/38/files#r1043485631
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated according to feedback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: