Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow custom request headers #38

Merged
merged 3 commits into from
Dec 11, 2022
Merged

allow custom request headers #38

merged 3 commits into from
Dec 11, 2022

Conversation

jihuang-adobe
Copy link
Contributor

@jihuang-adobe jihuang-adobe commented Nov 4, 2022

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@ghenzler
Copy link
Collaborator

@jihuang-adobe What is your use case that requires to set an additional header? Do you have some intermediate infrastructure that requires that header?

(I'm asking because potentially it could be better to explicitly provide the functionality over this generic approach, but it depends on if it is very specific to your setup or not)

@jihuang-adobe
Copy link
Contributor Author

jihuang-adobe commented Nov 30, 2022

Hi @ghenzler. I currently have AEM graphql endpoint behind a proxy. The proxy can potentially take a list of custom headers, so I thought it would be convenient if the AEM Headless Client would accept custom headers as an option.

src/index.js Outdated Show resolved Hide resolved
src/index.js Outdated Show resolved Hide resolved
Copy link
Contributor Author

@jihuang-adobe jihuang-adobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated according to feedback

Copy link
Collaborator

@easingthemes easingthemes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@easingthemes easingthemes merged commit 2cebf42 into adobe:main Dec 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants