Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SITES-10562 - Embed Youtube component not honoring Aspect ratio #1015

Merged
merged 2 commits into from Jan 12, 2023
Merged

SITES-10562 - Embed Youtube component not honoring Aspect ratio #1015

merged 2 commits into from Jan 12, 2023

Conversation

bpauli
Copy link
Contributor

@bpauli bpauli commented Jan 9, 2023

  • fix responsive YouTube embed

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bpauli bpauli merged commit 87a8f49 into develop Jan 12, 2023
@bpauli bpauli deleted the issue/embed-youtube-reponsive branch January 12, 2023 14:37
@barshat7 barshat7 added this to the 40 milestone Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Buuhuu Buuhuu Buuhuu approved these changes

@vladbailescu vladbailescu vladbailescu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
40
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bpauli @Buuhuu @vladbailescu @barshat7