Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui-test][fix] increase timeout, don't skip sites #1059

Merged
merged 14 commits into from Mar 27, 2023

Conversation

AlexRRR
Copy link
Collaborator

@AlexRRR AlexRRR commented Mar 27, 2023

Description

fixes two issues introduced to the UI test module:

  • forms tests may exceed the mocha timeout, increase to 4 mins.
  • reverting skip of sites test case.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@vladbailescu vladbailescu marked this pull request as ready for review March 27, 2023 14:54
@vladbailescu vladbailescu merged commit ff01ddb into adobe:develop Mar 27, 2023
9 checks passed
@barshat7 barshat7 added this to the 42 milestone Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants