FORMS-7603 forms core components changes #1074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rismehta
reviewed
May 17, 2023
src/main/archetype/pom.xml
Outdated
| @@ -83,8 +83,8 @@ | |||
|
|
|||
| #if ($includeForms == "y" or $includeFormsenrollment == "y" or $includeFormscommunications == "y" or $includeFormsheadless == "y") | |||
| #if ($aemVersion == "cloud") | |||
| <core.forms.components.version>2.0.14</core.forms.components.version> | |||
| <core.forms.components.af.version>2.0.14</core.forms.components.af.version> | |||
| <core.forms.components.version>2.0.16</core.forms.components.version> | |||
There was a problem hiding this comment.
Last released version is 2.0.14. https://github.com/adobe/aem-core-forms-components
| @@ -5,4 +5,4 @@ | |||
| jcr:title="Adaptive Form Container" | |||
| fd:version="2.1" | |||
| sling:resourceSuperType="core/fd/components/form/container/v2/container" | |||
| componentGroup=".${appTitle} - Adaptive Form"/> | |||
| componentGroup="${appTitle} - Adaptive Form"/> | |||
There was a problem hiding this comment.
@barshat7 , is this '.' removed intentionally
There was a problem hiding this comment.
yes, we will need to unhide to support forms in site
ujjwal5
reviewed
May 24, 2023
| @@ -1,6 +1,6 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <jcr:root xmlns:sling="http://sling.apache.org/jcr/sling/1.0" xmlns:cq="http://www.day.com/jcr/cq/1.0" xmlns:jcr="http://www.jcp.org/jcr/1.0" | |||
| jcr:primaryType="cq:Component" | |||
| jcr:title="AEM Forms Container" | |||
| jcr:title="Adaptive Form - Embed" | |||
| sling:resourceSuperType="core/fd/components/aemform/v1/aemform" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change Includes
Related Issue
FORMS-7603
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: