Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FORMS-9449 - Add first set of ootb core component AF templates to archetype #1095

Merged
merged 3 commits into from Jun 28, 2023

Conversation

pankaj-parashar
Copy link
Collaborator

@pankaj-parashar pankaj-parashar commented Jun 26, 2023

The following templates are added.

  • Benefits Enrollment
  • Consent Form
  • Contact Us Form
  • Give Feedback
  • Log Service Request

The following are the changes done.

  • Adding ootb templates with appId variables for resource paths
  • Adding theme reference for cloud service and 6.5
  • Adding thumbnails
  • Fixing header and footer policy
  • Template policy issue condition fixed
  • Fixing policy issue for benefits enrollment
  • Fixing logo issue using DAM image
  • Adding WKND logo filter entry
  • Added author metadata

Fixing top tab resource type

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Adding ootb templates with appId variables for resource paths

Adding theme reference for cloud service and 6.5

Adding thumbnails

Fixing header and footer policy

Template policy issue condition fixed

Fixing policy issue for benefits enrollment

Fixing logo issue using DAM image

Adding WKND logo filter entry

Added author metadata

Fixing top tab resource type
@pankaj-parashar pankaj-parashar changed the title FORMS-9449 - Add first set of core component AF templates to archetype FORMS-9449 - Add first set of ootb core component AF templates to archetype Jun 26, 2023
Copy link
Collaborator

@rismehta rismehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pankaj-parashar pankaj-parashar merged commit 22406fb into adobe:develop Jun 28, 2023
9 checks passed
@pankaj-parashar pankaj-parashar added this to the 43 milestone Jul 4, 2023
pankaj-parashar added a commit to pankaj-parashar/aem-project-archetype that referenced this pull request Jul 4, 2023
…hetype (adobe#1095)

* FORMS-9449 - Add first set of core component AF templates to archetype

Adding ootb templates with appId variables for resource paths

Adding theme reference for cloud service and 6.5

Adding thumbnails

Fixing header and footer policy

Template policy issue condition fixed

Fixing policy issue for benefits enrollment

Fixing logo issue using DAM image

Adding WKND logo filter entry

Added author metadata

Fixing top tab resource type

Fixing rule issue.

---------

Co-authored-by: Rishi Mehta <69448117+rismehta@users.noreply.github.com>
pankaj-parashar added a commit to pankaj-parashar/aem-project-archetype that referenced this pull request Jul 4, 2023
…hetype (adobe#1095)

* FORMS-9449 - Add first set of core component AF templates to archetype

Adding ootb templates with appId variables for resource paths

Adding theme reference for cloud service and 6.5

Adding thumbnails

Fixing header and footer policy

Template policy issue condition fixed

Fixing policy issue for benefits enrollment

Fixing logo issue using DAM image

Adding WKND logo filter entry

Added author metadata

Fixing top tab resource type

Fixing rule issue.

---------

Co-authored-by: Rishi Mehta <69448117+rismehta@users.noreply.github.com>
pankaj-parashar added a commit to pankaj-parashar/aem-project-archetype that referenced this pull request Jul 4, 2023
…hetype (adobe#1095)

* FORMS-9449 - Add first set of core component AF templates to archetype

Adding ootb templates with appId variables for resource paths

Adding theme reference for cloud service and 6.5

Adding thumbnails

Fixing header and footer policy

Template policy issue condition fixed

Fixing policy issue for benefits enrollment

Fixing logo issue using DAM image

Adding WKND logo filter entry

Added author metadata

Fixing top tab resource type

Fixing rule issue.

---------

Co-authored-by: Rishi Mehta <69448117+rismehta@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants