Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding .gitattributes to archetype-metadata.xml. Fixes #825. #826

Merged
merged 1 commit into from
Dec 16, 2021

Conversation

GuillaumeCleme
Copy link
Contributor

Description

Adding .gitattributes to archetype-metadata.xml. File previously added in #661 but missing from new projects when using the mvn -B archetype:generate command.

Related Issue

Motivation and Context

In certain development environments that may be configured with different GIT line ending configurations, it is possible for developers to unwillingly commit files with invalid line endings which will break the Dispatcher module's immutable file check due to invalid MD5 hashes.

How Has This Been Tested?

Yes. Steps included:

  • Adding changes locally
  • Building archetype project with mvn clean install -Pit-basic
  • Run mvn -B archetype:generate ... -DarchetypeVersion=31-SNAPSHOT
  • Confirm presence of .gitattributes in new project

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bpauli bpauli merged commit 727c226 into adobe:develop Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dispatcher immutable files pushed/cloned with invalid line endings
2 participants