Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct generated repoinit script #871

Merged

Conversation

golinski
Copy link
Contributor

@golinski golinski commented Jan 13, 2022

Description

Generated repoinit script (ui.config/src/main/content/jcr_root/apps/minimal/osgiconfig/config/org.apache.sling.jcr.repoinit.RepositoryInitializer~minimal.cfg.json) on 6.5 and cloud looks like this:

{
    "scripts": [
        "create path (sling:OrderedFolder) /content/dam/minimal",
        "create path (nt:unstructured) /content/dam/minimal/jcr:content",
        "set properties on /content/dam/minimal/jcr:content",
        "set cq:conf{String} to /conf/minimal",
        "set jcr:title{String} to \"Minimal\"",
        "end"
    ]
}

This PR merges the last four lines into a single script

{
    "scripts": [
        "create path (sling:OrderedFolder) /content/dam/minimal",
        "create path (nt:unstructured) /content/dam/minimal/jcr:content",
        "set properties on /content/dam/minimal/jcr:content\n  set cq:conf{String} to /conf/minimal\n  set jcr:title{String} to \"Minimal\"\nend"
    ]
}

Related Issue

#852

Motivation and Context

Solves the bug I've stumbled into with setting up a new project, turned out this is an open issue.

How Has This Been Tested?

Generated a project from the changed archetype, installed it on fresh 6.5.11. Restarted AEM. This worked, and did not work with latest v34.

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bpauli
Copy link
Contributor

bpauli commented Jan 13, 2022

@golinski Thanks a lot for providing this fix!

@bpauli bpauli merged commit 20a5aad into adobe:develop Jan 13, 2022
@bpauli bpauli linked an issue Jan 13, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with a RepositoryInitializer config preventing AEM restarts
2 participants