Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load js clientlibs async in customfooterlibs #934

Merged
merged 2 commits into from
May 23, 2022
Merged

Load js clientlibs async in customfooterlibs #934

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82ea0a2
Load js clientlibs async in customfooterlibs
Buuhuu May 20, 2022
644470b
revert changes to xfpage
Buuhuu May 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...ain/content/jcr_root/apps/__appId__/components/commerce/catalogpage/customfooterlibs.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
See the License for the specific language governing permissions and
limitations under the License.
*/-->
<sly data-sly-use.clientlib="/libs/granite/sightly/templates/clientlib.html">
<sly data-sly-call="${symbol_dollar}{clientlib.js @ categories='${appId}.base'}"/>
<sly data-sly-use.clientlib="core/wcm/components/commons/v1/templates/clientlib.html">
<sly data-sly-call="${symbol_dollar}{clientlib.js @ categories='${appId}.base', async=true}"/>
Buuhuu marked this conversation as resolved.
Show resolved Hide resolved
<sly data-sly-call="${symbol_dollar}{clientlib.js @ categories='${appId}.cif'}" />
</sly>
2 changes: 1 addition & 1 deletion ...ain/content/jcr_root/apps/__appId__/components/commerce/catalogpage/customheaderlibs.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
See the License for the specific language governing permissions and
limitations under the License.
*/-->
<sly data-sly-use.clientlib="/libs/granite/sightly/templates/clientlib.html">
<sly data-sly-use.clientlib="core/wcm/components/commons/v1/templates/clientlib.html">
<sly data-sly-call="${symbol_dollar}{clientlib.css @ categories='${appId}.base'}"/>
<sly data-sly-call="${symbol_dollar}{clientlib.css @ categories='${appId}.cif'}"/>
</sly>
Expand Down
4 changes: 2 additions & 2 deletions ...pe/ui.apps/src/main/content/jcr_root/apps/__appId__/components/page/customfooterlibs.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
See the License for the specific language governing permissions and
limitations under the License.
*/-->
<sly data-sly-use.clientlib="/libs/granite/sightly/templates/clientlib.html">
<sly data-sly-call="${symbol_dollar}{clientlib.js @ categories='${appId}.base'}"/>
<sly data-sly-use.clientlib="core/wcm/components/commons/v1/templates/clientlib.html">
<sly data-sly-call="${symbol_dollar}{clientlib.js @ categories='${appId}.base', async=true}"/>
#if ( $includeCommerce == "y" )
<sly data-sly-call="${symbol_dollar}{clientlib.js @ categories='${appId}.cif'}" />
#end
Expand Down
2 changes: 1 addition & 1 deletion ...pe/ui.apps/src/main/content/jcr_root/apps/__appId__/components/page/customheaderlibs.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
See the License for the specific language governing permissions and
limitations under the License.
*/-->
<sly data-sly-use.clientlib="/libs/granite/sightly/templates/clientlib.html">
<sly data-sly-use.clientlib="core/wcm/components/commons/v1/templates/clientlib.html">
<sly data-sly-call="${symbol_dollar}{clientlib.css @ categories='${appId}.base'}"/>
#if ( $includeCommerce == "y" )
<sly data-sly-call="${symbol_dollar}{clientlib.css @ categories='${appId}.cif'}" />
Expand Down