Skip to content
This repository has been archived by the owner on Feb 19, 2020. It is now read-only.

Improve archetype:generate command #107

Merged
merged 4 commits into from
Oct 17, 2019
Merged

Improve archetype:generate command #107

merged 4 commits into from
Oct 17, 2019

Conversation

samuelmeuli
Copy link
Contributor

@samuelmeuli samuelmeuli commented Oct 1, 2019

Q                       A
Fixed Issues? Fixes #41
Patch: Bug Fix? Yes
Minor: New Feature? No
Major: Breaking Change? No
Tests Added + Pass? No
Documentation Provided Yes (code comments and README)
Any Dependency Changes? Yes (updated maven-archetype-plugin)
License Apache License, Version 2.0
  • Updated maven-archetype-plugin from v3.0.1 to v3.1.2
  • Updated the default value of the artifactId archetype variable from ${groupId}.${projectName} to ${projectName} (which should be more in line with Maven's naming conventions: https://maven.apache.org/guides/mini/guide-naming-conventions.html)
  • Updated the archetype variables to require the minimum amount of user input (now only projectTitle, projectName, groupId and optionFrontend are required and have no more defaults, and the other variables can be derived from them). From my tests, Remove all default values from archetype required properties #41 seems to be resolved with these changes
  • Improved the parameter descriptions in the root README

@habansal habansal merged commit d041546 into adobe:development Oct 17, 2019
@samuelmeuli samuelmeuli deleted the archetype-default-values branch October 17, 2019 12:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants