Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unit tests for AnalyticsExtension #42

Closed
emdobrin opened this issue Feb 6, 2023 · 1 comment · Fixed by #49
Closed

unit tests for AnalyticsExtension #42

emdobrin opened this issue Feb 6, 2023 · 1 comment · Fixed by #49
Assignees
@emdobrin
Labels
task Item that can be completed as a standalone code change or is part of an epic.Used by issue template
Milestone
v2.0.1

Comments

@emdobrin
Copy link
Contributor

emdobrin commented Feb 6, 2023

Add more unit tests for the AnalyticsExtension class
Reenable all ignored tests, for integration tests create linked tasks/issue if they require changes in other extensions
@stcheng-adobe
Copy link

Try to match the code coverage in the iOS extension.

@emdobrin emdobrin added the task Item that can be completed as a standalone code change or is part of an epic.Used by issue template label Feb 7, 2023
@emdobrin emdobrin self-assigned this Feb 11, 2023
@emdobrin emdobrin linked a pull request Feb 13, 2023 that will close this issue
Increase code coverage to 90% (resolves #42) #49
Merged
10 tasks
emdobrin added a commit that referenced this issue Feb 14, 2023
@emdobrin
Increase code coverage to 90% (resolves #42) (#49)
3625510 
* Use helper functions, add more tests for AnalyticsExtension

* code cov++, test lines --

* replace usage of internal visitorIDSerializer with raw data handling

* tests ++ for listeners and analyticsState

* Add test for bg state

* unit tests for analyticsState ++

* Unit tests for generateAnalyticsCustomerIdString
@emdobrin emdobrin added this to the v2.0.1 milestone Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emdobrin emdobrin

Labels
task Item that can be completed as a standalone code change or is part of an epic.Used by issue template
Projects
None yet
Milestone
v2.0.1
Development

Successfully merging a pull request may close this issue.

Increase code coverage to 90% (resolves #42) emdobrin/aepsdk-analytics-android
2 participants
@emdobrin @stcheng-adobe