Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cached properties to get latest values from dataStore everytime #31

Merged
merged 5 commits into from
Feb 2, 2023

Conversation

addb
Copy link
Contributor

@addb addb commented Feb 2, 2023

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

companion object {
val CHARSET: String = StandardCharsets.UTF_8.name()
}


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Can you remove this extra line?

@emdobrin
Copy link
Contributor

emdobrin commented Feb 2, 2023

@addb changes look good, but there are some test failures on this one

@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Merging #31 (fa87426) into dev (4cb8d0f) will not change coverage.
The diff coverage is 86.66%.

@@            Coverage Diff            @@
##                dev      #31   +/-   ##
=========================================
  Coverage     79.38%   79.38%           
- Complexity      285      287    +2     
=========================================
  Files            15       15           
  Lines          1494     1494           
  Branches        183      183           
=========================================
  Hits           1186     1186           
  Misses          213      213           
  Partials         95       95           
Flag Coverage Δ
unit-functional-tests 79.38% <86.66%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...g/mobile/analytics/internal/AnalyticsProperties.kt 92.30% <81.81%> (ø)
...ng/mobile/analytics/internal/AnalyticsExtension.kt 69.77% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kevinlind kevinlind merged commit aba5550 into adobe:dev Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants