-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cached properties to get latest values from dataStore everytime #31
Conversation
companion object { | ||
val CHARSET: String = StandardCharsets.UTF_8.name() | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Can you remove this extra line?
@addb changes look good, but there are some test failures on this one |
Codecov Report
@@ Coverage Diff @@
## dev #31 +/- ##
=========================================
Coverage 79.38% 79.38%
- Complexity 285 287 +2
=========================================
Files 15 15
Lines 1494 1494
Branches 183 183
=========================================
Hits 1186 1186
Misses 213 213
Partials 95 95
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: