Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds issue templates, workflow renamings #44

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

emdobrin
Copy link
Contributor

@emdobrin emdobrin commented Feb 7, 2023

Description

Adds issue templates
Renames the release workflows

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@emdobrin emdobrin added the tooling Tooling updates and CI/CD improvements label Feb 7, 2023
@emdobrin emdobrin linked an issue Feb 7, 2023 that may be closed by this pull request
@emdobrin
Copy link
Contributor Author

emdobrin commented Feb 7, 2023

Looks like the app build fails with latest core 2.0.1-SNAPSHOTs, the Lifecycle snapshots depend on core 2.0.1 which is not available yet.
We have few options here:

  1. If the core extensions will always be released together, in core project update the script for snapshot gradle releases to point to core:x.y.z-SNAPSHOT.
  2. If core extensions are released independently, all other extensions should always point to a previously released core version core:x.y.z and not on snapshots.
  3. (somewhat independent on 1 and 2) Ignore snapshot versions with something like selection.reject https://docs.gradle.org/current/dsl/org.gradle.api.artifacts.ComponentSelectionRules.html

@addb
Copy link
Contributor

addb commented Feb 7, 2023

Looks like the app build fails with latest core 2.0.1-SNAPSHOTs, the Lifecycle snapshots depend on core 2.0.1 which is not available yet. We have few options here:

  1. If the core extensions will always be released together, in core project update the script for snapshot gradle releases to point to core:x.y.z-SNAPSHOT.
  2. If core extensions are released independently, all other extensions should always point to a previously released core version core:x.y.z and not on snapshots.
  3. (somewhat independent on 1 and 2) Ignore snapshot versions with something like selection.reject https://docs.gradle.org/current/dsl/org.gradle.api.artifacts.ComponentSelectionRules.html

I think we should always use full version - option 2

@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Merging #44 (cd6dcad) into dev-v2.0.1 (cf9f1b1) will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             dev-v2.0.1      #44   +/-   ##
=============================================
  Coverage         79.08%   79.08%           
  Complexity          286      286           
=============================================
  Files                15       15           
  Lines              1535     1535           
  Branches            180      180           
=============================================
  Hits               1214     1214           
  Misses              227      227           
  Partials             94       94           
Flag Coverage Δ
unit-functional-tests 79.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@emdobrin emdobrin merged commit bf92cd4 into adobe:dev-v2.0.1 Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling Tooling updates and CI/CD improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gh workflow setup
2 participants