Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor code and update doc comments #35

Merged
merged 2 commits into from
Mar 31, 2021
Merged

Refactor code and update doc comments #35

merged 2 commits into from
Mar 31, 2021

Conversation

praveek
Copy link
Contributor

@praveek praveek commented Mar 31, 2021

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@praveek praveek requested a review from rymorale March 31, 2021 19:24
rymorale
rymorale approved these changes Mar 31, 2021
View reviewed changes
Copy link
Contributor

@rymorale rymorale left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just a couple of minor things to update. feel free to merge after resolving.

@praveek praveek merged commit 4422f0e into adobe:dev-v3.0.1 Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rymorale rymorale rymorale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@praveek @rymorale