Merge dev into staging #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AssuranceFullScreenTakeoverActivity and AssuranceErrorDisplayActivity should only be able to be launched from implementing app context internally. Change the export flag to false to prevent this activity from being invoked from external contexts
Do not export internal Assurance activities
- Add NonNull annotations to public API's - Remove formatAnnotations() from spotless as it is behaving un expectedly (moves method annotation to same line) - Add a test for null check in public API
- Assruance has UI components that use constraint layout. Add this as a dependancy in POM so that the implementing app is not forced to add this in their gradle if they do not need it. - Prefix the style name for app theme with Assurance
Add ConstraintLayout POM dependency and fix style name
Add NonNull annotations to public API's
Refactor AssuranceTestApp for 2.0
Add GettingStarted and reorganize documentation structure
praveek
approved these changes
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge latest
devchanges intostaging