Make state fetching consistent with iOS #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code before 2.0 migration depended on Configuration for fetching reconnection scenario. However with Core 2.0 cofiguration state may not yet be available when Assurance reconnection starts. - Change the logic to be consistant with iOS and use the ordId from stored URL during reconnection scenarios. - Change shared state query logic to query with barrier = false to be consistent with iOS
prudrabhat
changed the title
praveek
reviewed
Dec 13, 2022
| String orgId = assuranceStateManager.getOrgId(true); | ||
|
|
||
| if (StringUtils.isNullOrEmpty(orgId)) { | ||
| // Configuration may not have set the state with org id yet. |
There was a problem hiding this comment.
Can you reword the comment to some thing like "If configuration does not have org-id, try extracting it from stored connection url"
praveek
approved these changes
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Code before 2.0 migration depended on Configuration for fetching reconnection scenario. However with Core 2.0 cofiguration state may not yet be available when Assurance reconnection starts.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: