Merge staging to main for 2.1.0 release #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add DeviceCreationTask to invoke /create api - Add DeviceStatusCheckerTask to invoke /status api - DeviceRegistrationWorker responsible for triggeing DeviceCreationTask and DeviceStatusCheckerTask
Implement Quick connect device registration workflow
Currently PIN based connection error codes and quick connect error codes exist separately. This distinction is not need and can be unified similar to Assurance iOS. - Unify AssuranceSockectError and AssuranceQuickConnect error to AssuranceConnectionError. - Add AssuranceConnectionError as a parameter to session status notifications to provide details of termination if any. This is useful for presentations like QuickConnect for managing their lifecycle by registerting as session status listeners as it is a native activity where dependency injection is not possble and reference to the activity/presentation for notifying chnages is not available.
Unify Assurance error codes
- Add AssuranceQuickConnectActivity for presenting UI
- Add the layouts, shapes and components for the QuickConnect screen.
This was not done in Jetpack because of 2 reasons:
1. 2.x adoption is not widespread yet. Our min sdk is 19 while Jetpack
supports 21+. So customers will have to do a forced minsdk upgrade of their apps
if we fix issues in a later version of Assurance after adopting jetpack.
2. Jetpack compose UI is better stabilized for Kotlin 1.5 and our min support is 1.4.
- Introduce an interface "SessionAuthorizingPresentation" which
represnts a presentation holder for different types of authorization
- Make AssurancePinEntryProvider (pin screen) and QuickConnectAuthorizingPresentation
implement SessionAuthorizingPresentation. This will allo AssuranceSessionPresentationManager
to hold either a pin authorizing screen or a quick connect authorizing screen
- Add onQuickConnect() as a new api in the SessionUIOperationHandler
- Modify the session creation parameters to take the type of presentation and an optional
handle to the presentation session listener to delegate ui changes in response to session.
- Add AssuranceComponentRegistry to enable native Android UI to access basic items needed for
creating a session i.e SessionUIOperationHandler and AssuranceStateManager.
QuickConnect UI and device API integration
Add public API for QuickConnect and integrate with AssuranceTestApp
- Bump the version to Assurance 2.1.0 for QuickConnect release - Fix the license link for distribution - Depend on the latest version of Core
Bump Assurance to 2.1.0 and fix license
Assurance currently uses and adds a theme but it is actually replacable via a simple color scheme. These may have been added by default while creating the module but are not necessary. In addtion, it imposes the theme requirement on the pure comopose apps implementing to have the standard xml color attributes. Remove themes from Assurance library.
Optimize size and remove theme usage inside Assurance library
A recent change that was done to remove themes missed switching AssuranceErrorDisplayActivity extend Activity. Switch it now.
Make AssuranceErrorDisplayActivity extend Activity
Merge dev into staging for 2.1.0 release prep
praveek
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merge
stagingtomainfor 2.1.0 release. This release contains changes to remove themes and add support for QuickConnect workflow on debug builds.Related Issue
N/A
Checklist: