Update to AGP 8.2 and migrate to aep-library plugin #84
Conversation
- Update to AGP 8.2 and use aep-library plugin for assurance library build.gradle. - Switch gradle files to use Kotlin DSL - Update Make file to latest javadoc task - Update circle ci to use jdk17 required for AGP 8.2
| } | ||
|
|
||
| composeOptions { | ||
| kotlinCompilerExtensionVersion = BuildConstants.Versions.COMPOSE_COMPILER |
There was a problem hiding this comment.
I would recommend that the test app defines it own version of compose instead of accessing it from the BuildConstants.
There was a problem hiding this comment.
Discussed that due the way extension projects are setup to use the Kotlin gradle plugin from the aep-library, we cannot use a version of Kotlin Compiler greater than what is defined there. When using a lower version, it should be compatible with the composeVersion being used. So decided to leave this as is and use a custom Compose version.
| resource-class: large | ||
| tag: 2022.01.1 | ||
| tag: 2024.01.1 |
There was a problem hiding this comment.
Can you also update the tag for functional tests?
| aepLibrary { | ||
| namespace = "com.adobe.marketing.mobile.assurance" | ||
| compose = true | ||
| //enableSpotless = true |
There was a problem hiding this comment.
Disabled spotless for this PR. Will enable this in the next PR to make the build pass.
code/assurance/build.gradle.kts
Outdated
| implementation("com.adobe.marketing.mobile:core:$mavenCoreVersion-SNAPSHOT") | ||
|
|
||
| // Compose Navigation | ||
| implementation("androidx.navigation:navigation-compose:2.4.0") |
There was a problem hiding this comment.
Can you also add these as publishing dependencies?
There was a problem hiding this comment.
Oops! Yes. Added them now.
Description
Related Issue
Motivation and Context
Prepare for the 3.x version of the library to be aligned with Core 3.x
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: